Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set collisionId in prunedGenParticles (11_2_X) #35471

Merged
merged 1 commit into from Oct 8, 2021

Conversation

mandrenguyen
Copy link
Contributor

PR description:

Backport of #35432

11_2_X was used for the reminiAOD of 2018 PbPb data and MC.
Some of the MC datasets will have to be reminiAOD'd with this fix.

Incidentally, I did not see an 11_2_X IB available.
Presumably there is very little development in this release, but hopefully we can build a new one at some point, although it's not very urgent.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for CMSSW_11_2_X.

It involves the following packages:

  • PhysicsTools/HepMCCandAlgos (analysis)

@cmsbuild, @santocch can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Oct 4, 2021

11_2_X was used for the reminiAOD of 2018 PbPb data and MC. Some of the MC datasets will have to be reminiAOD'd with this fix.

@mandrenguyen We closed 11_2_X recently as we thought this is not used anymore. @cms-sw/pdmv-l2 Can you confirm that 11_2_X is still used for productions?

@mandrenguyen
Copy link
Contributor Author

@qliphy 11_2_X is used for heavy-ion re-miniAOD. If we were starting a new re-miniAOD campaign, it would make sense to migrate to a newer release. However, in this case, we will simply need to rerun a few MC samples.

@qliphy
Copy link
Contributor

qliphy commented Oct 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6a4dce/19455/summary.html
COMMIT: 5d52968
CMSSW: CMSSW_11_2_X_2021-10-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35471/19455/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2537235
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2537212
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 151 log files, 37 edm output root files, 36 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Oct 8, 2021

+1

@qliphy
Copy link
Contributor

qliphy commented Oct 8, 2021

merge

@cmsbuild cmsbuild merged commit 4c19744 into cms-sw:CMSSW_11_2_X Oct 8, 2021
@qliphy
Copy link
Contributor

qliphy commented Oct 10, 2021

@mandrenguyen CMSSW_11_2_5_patch1which includes this PR is now available: https://hypernews.cern.ch/HyperNews/CMS/get/relAnnounce/2238.html

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will be automatically merged.

@mandrenguyen mandrenguyen deleted the collisionId_112X branch May 31, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants