Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS: RP id update in DQM common #35484

Merged
merged 2 commits into from Oct 1, 2021

Conversation

jan-kaspar
Copy link
Contributor

@jan-kaspar jan-kaspar commented Sep 30, 2021

PR description:

This PR updates CTPPSCommonDQMSource to use the RPs foreseen for Run 3, in particular:

  • it removes 210-near-hr (unused tracking RP)
  • it adds 220-near-hr (new timing RP)

This PR is independent of #35445 and #35454 - it modifies another module. This PR should conclude the changes in PPS DQM due to the new RP layout (most importantly the new timing RPs).

PR validation:

Below a screenshot of a DMQ file produced from 2018 data. In particular:

  • in the left column: RP 220-near-hr is present in the list and has the timing set of plots, conversely the 210-near-hr is missing
  • in the right part: the correlation histogram has the 220-near-hr on both axes.

dqm

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35484/25650

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jan-kaspar for master.

It involves the following packages:

  • DQM/CTPPS (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f4c9c2/19281/summary.html
COMMIT: e2e9bca
CMSSW: CMSSW_12_1_X_2021-09-29-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35484/19281/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3211008
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 10
  • DQMHistoTests: Total successes: 3210971
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -6.088 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 10024.0,... ): -0.338 KiB CTPPS/common
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 1, 2021

+1

@cmsbuild cmsbuild merged commit a686932 into cms-sw:master Oct 1, 2021
@jan-kaspar jan-kaspar deleted the pps_dqm_common_timing_id_update branch October 11, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants