New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10_2_X] Backport of O2O test setup modified to work across boost version changes #35517
[10_2_X] Backport of O2O test setup modified to work across boost version changes #35517
Conversation
A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_2_X. It involves the following packages:
@ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
type bug-fix |
backport of #35440 |
backport of #35472 |
@cmsbuild , please test |
@cmsbuild , please abort |
code-checks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35517/25724
|
@cmsbuild , please test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test EcalTPGPhysicsConst_O2O_test had ERRORS ---> test EcalTPGFineGrainTowerEE_O2O_test had ERRORS ---> test EcalTPGWeightIdMap_O2O_test had ERRORS ---> test EcalTPGFineGrainEBGroup_O2O_test had ERRORS and more ... Comparison SummarySummary:
|
11a6c05
to
c56d148
Compare
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b3f1c/19350/summary.html Comparison SummarySummary:
|
Unit tests pass now: Is there anything else to be done here @ggovi ? |
@tvami That's just it, thanks! |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
See description at #35440 and #35472
if this PR is a backport please specify the original PR and why you need to backport that PR:
backport of #35440 and #35472
resolves #28812