Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_2_X] Backport of O2O test setup modified to work across boost version changes #35517

Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Oct 3, 2021

PR description:

See description at #35440 and #35472

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #35440 and #35472

resolves #28812

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_2_X.

It involves the following packages:

  • CondCore/Utilities (db)
  • CondTools/Ecal (db)

@ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @mmusich, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

type bug-fix

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

backport of #35440

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

backport of #35472

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

@cmsbuild , please abort

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35517/25724

  • This PR adds an extra 40KB to repository

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b3f1c/19349/summary.html
COMMIT: 11a6c05
CMSSW: CMSSW_10_2_X_2021-10-03-0000/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35517/19349/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test EcalTPGPhysicsConst_O2O_test had ERRORS
---> test EcalTPGFineGrainTowerEE_O2O_test had ERRORS
---> test EcalTPGWeightIdMap_O2O_test had ERRORS
---> test EcalTPGFineGrainEBGroup_O2O_test had ERRORS
and more ...

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007353
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@tvami tvami force-pushed the condcore-utilities-fix-o2otest-102X branch from 11a6c05 to c56d148 Compare October 3, 2021 22:02
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 3, 2021

Pull request #35517 was updated. @ggovi, @malbouis, @cmsbuild, @tvami, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Oct 3, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b3f1c/19350/summary.html
COMMIT: c56d148
CMSSW: CMSSW_10_2_X_2021-10-03-0000/slc6_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35517/19350/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007546
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007354
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 28 edm output root files, 31 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor Author

tvami commented Oct 4, 2021

Unit tests pass now:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b3f1c/19350/unitTests/success.html

Is there anything else to be done here @ggovi ?

@ggovi
Copy link
Contributor

ggovi commented Oct 4, 2021

@tvami That's just it, thanks!

@ggovi
Copy link
Contributor

ggovi commented Oct 4, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 4, 2021

+1
Duplicate Dictionaries Warning already in IB

@cmsbuild cmsbuild merged commit faf102b into cms-sw:CMSSW_10_2_X Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants