Removal of the unused class of SiPixelCPEGenericDBErrorParametrization

[tvami]

PR description:

Removal of the unused class of SiPixelCPEGenericDBErrorParametrization. It's been taken over by the PixelCPEGeneric algorithm years ago (about 2008). Please note that the corresponding tag from the GTs have been removed in the past already, this is just the code cleaning part of it.

Edit:

• SiPixelDBTest_cfg.py is removed, an improved version of this can be found under CondTools/SiPixel

PR validation:

Tested with

runTheMatrix.py -l 11634.0 -j 8

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport and no backport is needed

resolves cms-AlCaDB/AlCaTools#33

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35545/25774

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• CalibTracker/SiPixelESProducers (alca)
• RecoLocalTracker/SiPixelRecHits (reconstruction)

@malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mtosi, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @OzAmram, @ferencek, @dkotlins, @rovere, @gpetruc, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20dea2/19420/summary.html
COMMIT: 22f01b9
CMSSW: CMSSW_12_1_X_2021-10-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35545/19420/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3219394
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219366
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[ferencek]

Thanks, @tvami, for going ahead with the cleanup. What about the related CondFormat SiPixelCPEGenericErrorParm (https://cmssdt.cern.ch/dxr/CMSSW/search?q=SiPixelCPEGenericErrorParm&case=true)? I guess that one is also no longer actively used and can be removed.

[tvami]

Hi @ferencek I removed some of what you are referring to. However there is an AlCa policy not to remove the record definition and registration. I'm not sure what to do with a record that has really never been used in production, we'll discuss this inside AlCa and I'll come back to this tomorrow

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35545/25780

• This PR adds an extra 24KB to repository

[cmsbuild]

Pull request #35545 was updated. @malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @francescobrivio, @tvami can you please check and sign again.

[tvami]

@cmsbuild , please test

[tvami]

@ferencek the files under CondFormats/SiPixelObjects and CondFormats/DataRecord/ need to be kept due to the CMS policy about the records in the database. If you prefer I can remove them from ESProducer. Otherwise, I'd keep the PR as it is. Please let me know.

Looking at https://cmssdt.cern.ch/dxr/CMSSW/search?q=SiPixelFakeCPEGenericErrorParmESSource&case=true it looks like the SiPixelFakeCPEGenericErrorParmESSource .h, .cc, and cfi files can be removed.

Done

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35545/25803

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #35545 was updated. @malbouis, @yuanchao, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20dea2/19449/summary.html
COMMIT: 8fe467e
CMSSW: CMSSW_12_1_X_2021-10-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35545/19449/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3219394
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219372
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

Jenkins test pass nicely, no diff found, the SA only has a single warning for the bricked design

[malbouis]

+alca

[slava77]

+reconstruction

for #35545 8fe467e

• code changes in reco are technical, following up the removal in CalibTracker; also, SiPixelDBTest_cfg.py is removed which seems to be OK (although some note about it would be nice in the PR description)
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[tvami]

(although some note about it would be nice in the PR description)

I updated the PR description now @slava77