Migrate module config in RecoTracker{TkSeedingLayers} to use default seedingLayersEDProducer in cfipython

[jeongeun]

PR description:

Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations.
This is a follow-up PR from PR#35194.
As commented from slava in this PR, we replaced "cms.PSet" in module "seedingLayersEDProducer" with "dict".

In this PR, 9 files changed.
modified: RecoTracker/TkSeedingLayers/python/DisplacedGeneralLayerTriplet_cfi.py
modified: RecoTracker/TkSeedingLayers/python/MixedLayerPairs_cfi.py
modified: RecoTracker/TkSeedingLayers/python/MixedLayerTriplets_cfi.py
modified: RecoTracker/TkSeedingLayers/python/PixelAndStripLayerPairs_cfi.py
modified: RecoTracker/TkSeedingLayers/python/PixelLayerPairs_cfi.py
modified: RecoTracker/TkSeedingLayers/python/PixelLayerTriplets_cfi.py
modified: RecoTracker/TkSeedingLayers/python/PixelLessLayerPairs4PixelLessTracking_cfi.py
modified: RecoTracker/TkSeedingLayers/python/PixelLessLayerPairs_cfi.py
modified: RecoTracker/TkSeedingLayers/python/TobTecLayerPairs_cfi.py

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_1_X, the basic test all passed in the CMSSW PR instructions.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35549/25781

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• RecoTracker/TkSeedingLayers (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab4b9a/19427/summary.html
COMMIT: 3e82104
CMSSW: CMSSW_12_1_X_2021-10-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35549/19427/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3219394
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219371
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jpata]

A very minor stylistic comment inline.
I did a diff between the config dump from 11834.21/step3 before & after this PR and saw no change, as expected.

[jpata]

I'm not sure if I understand why the comment was moved, I would think this is clearer:

Suggested change

	'TIB1+TID1_pos', # 'TIB1+TID2_pos',
	'TIB1+TID1_neg', # 'TIB1+TID2_neg',
	'TIB1+TID1_pos',
	# 'TIB1+TID2_pos',
	'TIB1+TID1_neg',
	# 'TIB1+TID2_neg',

[jpata]

same would apply here with respect to the commented-out part.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35549/25856

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #35549 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

[jpata]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab4b9a/19515/summary.html
COMMIT: 5c27558
CMSSW: CMSSW_12_1_X_2021-10-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35549/19515/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2798082
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2798060
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[jpata]

+reconstruction

• technical python config update
• no reco changes expected/observed
• the config dump was also diffed, no change

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1