PR121X L1T Calo - Remove retrieving conditions via config #35554

rekovic · 2021-10-06T09:19:54Z

PR description:

This PR removes part of the configuration of L1T Calo which retrieves conditions from a specific location (instead of via GT) and which is deprecated for a while (non-used since we moved away from hacking conditions).

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

rekovic · 2021-10-06T09:20:03Z

please test

cmsbuild · 2021-10-06T09:25:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35554/25785

This PR adds an extra 16KB to repository

cmsbuild · 2021-10-06T09:26:21Z

A new Pull Request was created by @rekovic for master.

It involves the following packages:

L1Trigger/L1TCalorimeter (l1)

@rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2021-10-06T10:17:00Z

-1

Failed Tests: RelVals AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5cd36/19432/summary.html
COMMIT: 1fd5ee9
CMSSW: CMSSW_12_1_X_2021-10-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35554/19432/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.731

----- Begin Fatal Exception 06-Oct-2021 11:46:03 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 274199 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

136.793

----- Begin Fatal Exception 06-Oct-2021 11:46:04 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 301998 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

136.874

----- Begin Fatal Exception 06-Oct-2021 11:46:11 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 319450 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

AddOn Tests

hlt_mc_Fake2

----- Begin Fatal Exception 06-Oct-2021 11:48:09 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 3
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 06-Oct-2021 11:48:21 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 06-Oct-2021 11:48:27 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 2
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

panoskatsoulis · 2021-10-20T12:30:36Z

Hi @rekovic,
this seems to be some rcd required for running the packer (?) and was fetched specifically by some older tag [1].
After checking the ProdDB, here is a list [2] with all the GTs that include this required tag.
Now these relval campaigns, if I'm not mistaken, they use auto:run2_hlt_relval that points to the GT 121X_dataRun_HLT_relval_v5 according to this file [3].

[1] https://github.com/cms-sw/cmssw/pull/35554/files#diff-abbcc16c4affd0b74172e2ce9e7d7b325c8e0bc495968664bd457e36cf7c9444L55
[2]

121X_mcRun2_design_Candidate_2021_10_14_16_25_03
121X_mcRun2_design_Queue
121X_mcRun2_design_v1
121X_mcRun2_design_v2
121X_mcRun2_design_v3
121X_mcRun2_design_v4
121X_mcRun2_design_v5
121X_mcRun2_design_v6
121X_mcRun2_pA_Candidate_2021_10_14_16_25_28
121X_mcRun2_pA_Queue
121X_mcRun2_pA_v1
121X_mcRun2_pA_v2
121X_mcRun2_pA_v3
121X_mcRun2_pA_v4
121X_mcRun2_pA_v5
121X_mcRun2_pA_v6
121X_mcRun2_startup_Candidate_2021_10_14_16_25_57
121X_mcRun2_startup_Queue
121X_mcRun2_startup_v1
121X_mcRun2_startup_v2
121X_mcRun2_startup_v3
121X_mcRun2_startup_v4
121X_mcRun2_startup_v5
121X_mcRun2_startup_v6

[3] https://github.com/cms-sw/cmssw/blob/master/Configuration/AlCa/python/autoCond.py#L37

hjkwon260 · 2021-10-20T14:07:45Z

Thanks @panoskatsoulis for checking it

@ggovi @tvami @francescobrivio @malbouis
After L1 removed 'L1TCaloParamsO2ORcd' which was previously manually defined in the code(please see changed file), this issue happens and our quick suggestion is to include this tag and test wf with candidate GT first. However I see there are none of tags available with 'L1TCaloParamsO2ORcd' in the condDB. https://cms-conddb.cern.ch/cmsDbBrowser/search/Prod/L1TCaloParamsO2ORcd

Was this record entirely removed from the database? If then could you please suggest how we should proceed?

tvami · 2021-10-20T14:37:12Z

This record is consumed here

cmssw/L1Trigger/L1TCalorimeter/plugins/L1TStage2Layer2Producer.cc

Lines 126 to 130 in 6d2f660

    
           // get static config flag 
        
           m_useStaticConfig = ps.getParameter<bool>("useStaticConfig"); 
        
           if (!m_useStaticConfig) { 
        
             m_o2oProtoToken = esConsumes<CaloParams, L1TCaloParamsO2ORcd, edm::Transition::BeginRun>(); 
        
           }

Please remove that as well. Thanks

panoskatsoulis · 2021-10-20T15:14:11Z

Hi, I'm not sure we want to drop the code that @tvami links (maybe @rekovic can clarify)
my understanding is that this part of the code has stopped working because of the changes by this PR
and the main reason is that the current GTs that are used for these wf/relvals do not include this static Tag
L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET

Also, @hjkwon260 maybe I miss smth but I am able to see the Tag above from the conddb cli.
actually I get the following info about the required tag in many 121X GTs and also the payload

[kpanos@lxplus755 src]$ conddb listGTsForTag L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET | grep ^121X
[2021-10-20 17:12:44,524] INFO: Connecting to pro [frontier://PromptProd/cms_conditions]
121X_mcRun2_design_Candidate_2021_10_14_16_25_03                L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_design_Queue                                        L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_design_v1                                           L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_design_v2                                           L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_design_v3                                           L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_design_v4                                           L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_design_v5                                           L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_design_v6                                           L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_pA_Candidate_2021_10_14_16_25_28                    L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_pA_Queue                                            L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_pA_v1                                               L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_pA_v2                                               L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_pA_v3                                               L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_pA_v4                                               L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_pA_v5                                               L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_pA_v6                                               L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_startup_Candidate_2021_10_14_16_25_57               L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_startup_Queue                                       L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_startup_v1                                          L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_startup_v2                                          L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_startup_v3                                          L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_startup_v4                                          L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_startup_v5                                          L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -       
121X_mcRun2_startup_v6                                          L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET  L1TCaloParamsRcd  -

conddb list L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET
Since: Run   Insertion Time       Payload                                   Object Type       
-----------  -------------------  ----------------------------------------  ---------------   
1            2017-08-25 09:58:18  5ec1648ad9a1729421c010ecf9e7b01640b4c316  l1t::CaloParams

hjkwon260 · 2021-10-20T15:21:56Z

@panoskatsoulis "L1TCaloParamsO2ORcd" is the record complained from event setup not "L1TCaloParamsRcd"
We use "L1TCaloParamsRcd" of course (for o2o and in mc)

tvami · 2021-10-20T15:22:02Z

@panoskatsoulis yes that's the reason for the failure, but @rekovic claims that this tag is not used. So if it's not used (i.e. m_useStaticConfig is false) let's removing the consumption of it from the code (actually everything that's under m_useStaticConfig), if it is used, we need to provide a new GT. The name of the tag L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET kind of shows that this is very outdate anyway...

tvami · 2021-10-20T15:22:33Z

@panoskatsoulis "L1TCaloParamsO2ORcd" is the record complained from event setup not "L1TCaloParamsRcd" We use "L1TCaloParamsRcd" of course (for o2o and in mc)

Yes indeed

panoskatsoulis · 2021-10-20T15:27:38Z

@panoskatsoulis "L1TCaloParamsO2ORcd" is the record complained from event setup not "L1TCaloParamsRcd" We use "L1TCaloParamsRcd" of course (for o2o and in mc)

Aah.. you're right
I missed that "O2O" - so in any case by including the Tag in any Candidate is not gonna solve it anyway

thank you both for replying fast

hjkwon260 · 2021-10-20T15:41:27Z

We should not include L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET in any of GTs since it's type is L1TCaloParamsRcd. It will replace up-to-date data/mc tag, which shoudn't happen

tvami · 2021-10-20T15:46:20Z

We should not include L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET in any of GTs since it's type is L1TCaloParamsRcd. It will replace up-to-date data/mc tag, which shoudn't happen

Thanks for confirming, so then the way to go is what I've suggested here #35554 (comment)

mmusich · 2021-10-20T16:04:59Z

We should not include L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET in any of GTs since it's type is L1TCaloParamsRcd. It will replace up-to-date data/mc tag, which shouldn't happen

I am sorry to chime in - Tamas casually pointed me to this PR - but I couldn't help noticing that this statement is somewhat inaccurate.
The C++ type underlying the payload in L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET is rather l1t::CaloParams and that can be used for both records (L1TCaloParamsRcd and L1TCaloParamsO2ORcd)

cmssw/CondCore/L1TPlugins/src/UpgradeRecords1.cc

Lines 8 to 10 in 56cd795

    
           using namespace l1t; 
        
           REGISTER_PLUGIN(L1TCaloParamsO2ORcd, CaloParams); 
        
           REGISTER_PLUGIN(L1TCaloParamsRcd, CaloParams);

The question is about providing a hook in GT for L1TCaloParamsO2ORcd and NOT L1TCaloParamsRcd.
Having said that if the code that consumes L1TCaloParamsO2ORcd can be removed that's easier for the GT maintainers.

hjkwon260 · 2021-10-20T17:22:45Z

We should not include L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET in any of GTs since it's type is L1TCaloParamsRcd. It will replace up-to-date data/mc tag, which shouldn't happen

I am sorry to chime in - Tamas casually pointed me to this PR - but I couldn't help noticing that this statement is somewhat inaccurate. The C++ type underlying the payload in L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET is rather l1t::CaloParams and that can be used for both records (L1TCaloParamsRcd and L1TCaloParamsO2ORcd)

@mmusich sorry I agree the word type I used can bring misunderstanding, I was rather trying to refer record name if it's a better notation. However the claim I made should be right as far as I understand, since the record name is L1TCaloParamsRcd for this outdated tag, it will replace the correct existing tag under same record name.(correct me if I'm wrong!)
You are right that both record share same type, which I think is the reason why this was possible:

cmssw/L1Trigger/L1TCalorimeter/python/simDigis_cff.py

Lines 53 to 55 in cf979a1

    
           cms.PSet( 
        
                record = cms.string('L1TCaloParamsO2ORcd'), 
        
                tag = cms.string("L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET")

The question is about providing a hook in GT for L1TCaloParamsO2ORcd and NOT L1TCaloParamsRcd.

Indeed this was what we needed as suggestion.

On the other hand, wouldn't it also work then replace L1TCaloParamsO2ORcd to L1TCaloParamsRcd in consuming codes,
which probably safer than removing those parts?

mmusich · 2021-10-20T19:05:30Z

@hjkwon260

However the claim I made should be right as far as I understand, since the record name is L1TCaloParamsRcd for this outdated tag, it will replace the correct existing tag under same record name.(correct me if I'm wrong!)

I am not sure to follow you here. The custom ESSource that is removed in this PR supplies the tag L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET on the record L1TCaloParamsO2ORcd not L1TCaloParamsRcd.
The failure in the PR integration tests demonstrates that the source code is expecting some ESSource to supply data on the record L1TCaloParamsO2ORcd (be it custom or the GlobalTag one), since when it's removed the code is crashing.
If the tag L1TCaloParams_static_CMSSW_9_2_10_2017_v1_8_2_updateHFSF_v6MET in included in the various autoCond Global Tags (if associated to L1TCaloParamsO2ORcd) it will restore the same situation before the removal of the custom ESSource and won't override any other data on that record (since we know that when the ESSource is removed the data is missing).

tvami · 2021-10-25T06:29:33Z

assign alca

cmsbuild · 2021-10-25T06:29:53Z

New categories assigned: alca

@yuanchao,@francescobrivio,@malbouis,@tvami you have been requested to review this Pull request/Issue and eventually sign? Thanks

tvami · 2021-10-25T06:30:19Z

Having said that if the code that consumes L1TCaloParamsO2ORcd can be removed that's easier for the GT maintainers.

I understand from @rekovic that it can be removed. Please confirm.

Can we please have an answer to this?

rekovic · 2021-10-28T11:27:26Z

Hi @tvami , #35554 (comment)
Yes, that is correct. It is the point of this PR.

If the suggestion of @mmusich in #35554 (comment) is for this code here to be removed as well in this PR that can be done.

Note that it is executed only if flag ps.getParameter<bool>("useStaticConfig") is set to True. The default configuration is False ( see here )

mmusich · 2021-10-28T11:35:39Z

Note that it is executed only if flag ps.getParameter("useStaticConfig") is set to True. The default configuration is False ( see here )

Apparently it is picked up in some instances as True in RelVals and unit tests, otherwise the integration test wouldn't have failed on missing L1TCaloParamsO2ORcd when the ESSource is removed : cf #35554 (comment)

rekovic · 2021-10-28T13:37:52Z

Hm, the instances as useStaticConfig=True I expected only to be used by experts and developers (e.g. @bundocka )
Let me restart the tests to access the results directories with workflow configs (the ones from previous tests deleted)

rekovic · 2021-10-28T13:38:00Z

please test

cmsbuild · 2021-10-28T14:40:25Z

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5cd36/20017/summary.html
COMMIT: 1fd5ee9
CMSSW: CMSSW_12_1_X_2021-10-27-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35554/20017/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

RelVals

136.731

----- Begin Fatal Exception 28-Oct-2021 15:58:02 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 274199 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

136.793

----- Begin Fatal Exception 28-Oct-2021 15:58:04 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 301998 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

136.874

----- Begin Fatal Exception 28-Oct-2021 15:58:08 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 319450 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

134.813134.813_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2/step2_RunCosmics2015C+RunCosmics2015C+RECOCOSDRUN2+ALCACOSDRUN2+HARVESTDCRUN2.log
136.723136.723_RunDoubleMuon2016B+RunDoubleMuon2016B+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2/step2_RunDoubleMuon2016B+RunDoubleMuon2016B+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2.log
136.721136.721_RunHLTPhy2016B+RunHLTPhy2016B+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2/step2_RunHLTPhy2016B+RunHLTPhy2016B+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_Fake2

----- Begin Fatal Exception 28-Oct-2021 15:58:43 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 1
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 28-Oct-2021 15:59:17 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

hlt_mc_HIon

----- Begin Fatal Exception 28-Oct-2021 15:59:29 CEST-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  stream begin Run run: 1 stream: 0
   [1] Calling method for module L1TStage2Layer2Producer/'simCaloStage2Digis'
Exception Message:
No "L1TCaloParamsO2ORcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

tvami · 2021-11-03T17:01:52Z

@rekovic any news on this?

tvami · 2021-11-05T00:33:03Z

(the ones from previous tests deleted)

The results from the test one week ago are still available, but I'm afraid not for very long

tvami · 2021-11-11T23:27:07Z

It's been another week

tvami · 2021-11-24T23:26:06Z

It's been another week

Another two weeks now, any news? @rekovic

tvami · 2021-11-30T19:33:37Z

It's been another week

Another two weeks now, any news? @rekovic

Weekly ping :)
@panoskatsoulis maybe you have better access to @rekovic ? :)

tvami · 2021-12-06T19:49:47Z

Another Monday, @hjkwon260 maybe?

tvami · 2021-12-08T02:44:43Z

Fine, I did it myself, please see #36408

tvami · 2021-12-08T02:45:30Z

-alca

perrotta · 2022-02-22T13:14:03Z

Moved in #36408 (now merged) after long inactivity here.
As far as I can see, this PR can be closed

Remove non-unsed part of configuration.

1fd5ee9

cmsbuild added this to the CMSSW_12_1_X milestone Oct 6, 2021

cmsbuild added code-checks-pending l1-pending orp-pending pending-signatures tests-started labels Oct 6, 2021

rekovic mentioned this pull request Oct 6, 2021

L1T Calo - Remove retrieving conditions via config #35553

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 6, 2021

cmsbuild added tests-rejected and removed tests-started labels Oct 6, 2021

tvami mentioned this pull request Oct 20, 2021

Developers overriding production location for retrieving conditions in configurations #27393

Closed

cmsbuild added the alca-pending label Oct 25, 2021

cmsbuild added tests-started and removed tests-rejected labels Oct 28, 2021

cmsbuild added tests-rejected and removed tests-started labels Oct 28, 2021

smuzaffar modified the milestones: CMSSW_12_1_X, CMSSW_12_2_X Oct 29, 2021

smuzaffar modified the milestones: CMSSW_12_2_X, CMSSW_12_3_X Dec 6, 2021

tvami mentioned this pull request Dec 8, 2021

Removal of hardcoded testing L1T tag and move it to GT #36408

Merged

cmsbuild added alca-rejected and removed alca-pending labels Dec 8, 2021

perrotta closed this Feb 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PR121X L1T Calo - Remove retrieving conditions via config #35554

PR121X L1T Calo - Remove retrieving conditions via config #35554

rekovic commented Oct 6, 2021

rekovic commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

panoskatsoulis commented Oct 20, 2021 •

edited

hjkwon260 commented Oct 20, 2021 •

edited

tvami commented Oct 20, 2021 •

edited

panoskatsoulis commented Oct 20, 2021 •

edited

hjkwon260 commented Oct 20, 2021

tvami commented Oct 20, 2021

tvami commented Oct 20, 2021

panoskatsoulis commented Oct 20, 2021

hjkwon260 commented Oct 20, 2021

tvami commented Oct 20, 2021

mmusich commented Oct 20, 2021

hjkwon260 commented Oct 20, 2021

mmusich commented Oct 20, 2021

tvami commented Oct 25, 2021 •

edited

cmsbuild commented Oct 25, 2021

tvami commented Oct 25, 2021

rekovic commented Oct 28, 2021

mmusich commented Oct 28, 2021

rekovic commented Oct 28, 2021

rekovic commented Oct 28, 2021

cmsbuild commented Oct 28, 2021

tvami commented Nov 3, 2021

tvami commented Nov 5, 2021

tvami commented Nov 11, 2021

tvami commented Nov 24, 2021

tvami commented Nov 30, 2021

tvami commented Dec 6, 2021

tvami commented Dec 8, 2021

tvami commented Dec 8, 2021

perrotta commented Feb 22, 2022

PR121X L1T Calo - Remove retrieving conditions via config #35554

PR121X L1T Calo - Remove retrieving conditions via config #35554

Conversation

rekovic commented Oct 6, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

rekovic commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

cmsbuild commented Oct 6, 2021

RelVals

AddOn Tests

panoskatsoulis commented Oct 20, 2021 • edited

hjkwon260 commented Oct 20, 2021 • edited

tvami commented Oct 20, 2021 • edited

panoskatsoulis commented Oct 20, 2021 • edited

hjkwon260 commented Oct 20, 2021

tvami commented Oct 20, 2021

tvami commented Oct 20, 2021

panoskatsoulis commented Oct 20, 2021

hjkwon260 commented Oct 20, 2021

tvami commented Oct 20, 2021

mmusich commented Oct 20, 2021

hjkwon260 commented Oct 20, 2021

mmusich commented Oct 20, 2021

tvami commented Oct 25, 2021 • edited

cmsbuild commented Oct 25, 2021

tvami commented Oct 25, 2021

rekovic commented Oct 28, 2021

mmusich commented Oct 28, 2021

rekovic commented Oct 28, 2021

rekovic commented Oct 28, 2021

cmsbuild commented Oct 28, 2021

Unit Tests

RelVals

RelVals-INPUT

AddOn Tests

tvami commented Nov 3, 2021

tvami commented Nov 5, 2021

tvami commented Nov 11, 2021

tvami commented Nov 24, 2021

tvami commented Nov 30, 2021

tvami commented Dec 6, 2021

tvami commented Dec 8, 2021

tvami commented Dec 8, 2021

perrotta commented Feb 22, 2022

panoskatsoulis commented Oct 20, 2021 •

edited

hjkwon260 commented Oct 20, 2021 •

edited

tvami commented Oct 20, 2021 •

edited

panoskatsoulis commented Oct 20, 2021 •

edited

tvami commented Oct 25, 2021 •

edited