Improve HGCAL geometry handling in fireworks

[rovere]

PR description:

• Trying to open the object panel in Fireworks while displaying
  Tracksters, an error appears complaining about a missing symbol. That
  was due to a declaration without any implementation of a trackster's
  method. This removes that.

• Make use of the topology information, in the form of 9 floats for each
  DetId, to pass HGCAL specific information to Fireworks. This will avoid
  the weak and error-prone practice of unpacking the DetId bits while
  rendering the objects via the dedicated proxies. Three floats are still
  available. This will increase the coupling between the release, the
  geometry dumping and the explored file. On the other hand, at present,
  the unpacking is wrong for new geometries.

• Rename private variables with a final '_', in accordance to CMSSW coding
  rules. Also, make use of the topology information now stored inside the
  geometry description of Fireworks. This makes the code easier to read
  and maintain. Finally, make Trackster-as-layer fully heatmap compatible.

PR validation:

usual runTheMatrix.py -l limited -i all

if this PR is a backport please specify the original PR and why you need to backport that PR:

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35558/25791

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

• DataFormats/HGCalReco (upgrade, reconstruction)
• Fireworks/Calo (visualization)
• Fireworks/Geometry (visualization)

@Dr15Jones, @alja, @makortel, @cmsbuild, @AdrianoDee, @srimanob, @slava77, @jpata can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[rovere]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9b6982/19435/summary.html
COMMIT: 02e8168
CMSSW: CMSSW_12_1_X_2021-10-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35558/19435/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 3219394
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3219366
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[alja]

+1

[slava77]

+reconstruction

for #35558 02e8168

• code changes are trivial for reco, removing an unimplemented method in DataFormats/HGCalReco/interface/Trackster.h
• jenkins tests pass

[rovere]

ping upgrade

[srimanob]

+Upgrade

For the upgrade related code, only technical change is implemented. One unused inline function is removed.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1