Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[120X] Add GTs for Run-3 test beam data taking + edit DQM unit test run number and dataset #35561

Merged
merged 4 commits into from Oct 14, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Oct 6, 2021

PR description:

Global Tag change:

HN:
https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/4488.html

Edit:

  • now this PR contains changes in the DQM unit tests, to test a more recent CRUZET run

PR validation:

Was tested at P5 for DQM

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport, needed for DQM testing

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2021

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_0_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

Pull request #35561 was updated. @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @francescobrivio, @pbo0, @rvenditti can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

Pull request #35561 was updated. @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @francescobrivio, @pbo0, @rvenditti can you please check and sign again.

@tvami tvami changed the title [120X] Add GTs for Run-3 test beam data taking [120X] Add GTs for Run-3 test beam data taking + edit DQM unit test run number and dataset Oct 7, 2021
@jfernan2
Copy link
Contributor

jfernan2 commented Oct 7, 2021

please test

@tvami
Copy link
Contributor Author

tvami commented Oct 7, 2021

@jfernan2 this will fail alone, since now the Run-3 era change is missing, so that's why I only triggered tests in #35551

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 7, 2021

You are right, however in the UnitTests that I did privately I did not see the crash, so I wanted to find out why

@tvami
Copy link
Contributor Author

tvami commented Oct 7, 2021

@cmsbuild , ping

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

Pull request #35561 was updated. @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @francescobrivio, @pbo0, @rvenditti can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Oct 7, 2021

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35561/25827

  • This PR adds an extra 20KB to repository

@tvami
Copy link
Contributor Author

tvami commented Oct 8, 2021

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Oct 8, 2021

@cmsbuild , please test with #35551

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12aee9/19486/summary.html
COMMIT: 648b5a9
CMSSW: CMSSW_12_0_X_2021-10-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35561/19486/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Oct 8, 2021

+1
Tested in Online DQM at P5 along with #35551

@francescobrivio
Copy link
Contributor

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor Author

tvami commented Oct 8, 2021

Done

@tvami
Copy link
Contributor Author

tvami commented Oct 9, 2021

@perrotta @qliphy as mentioned in the other PR, this needs to be merged together with #35551

@qliphy
Copy link
Contributor

qliphy commented Oct 14, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants