Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pytest and anyio unit test #35564

Merged
merged 2 commits into from Oct 10, 2021
Merged

Adding pytest and anyio unit test #35564

merged 2 commits into from Oct 10, 2021

Conversation

smuzaffar
Copy link
Contributor

@smuzaffar smuzaffar commented Oct 7, 2021

pytest is broken in 12.1.0.pre3 due to missing anyio dependencies (see cms-sw/cmsdist#7365). This PR proposes to add simple unit tests for anyio, sniffio and pytest .

This should be merged with cms-sw/cmsdist#7366

@smuzaffar
Copy link
Contributor Author

please test with cms-sw/cmsdist#7366

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35564/25807

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • PhysicsTools/PythonAnalysis (analysis)

@santocch can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c8ad10/19453/summary.html
COMMIT: bc67fd8
CMSSW: CMSSW_12_1_X_2021-10-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35564/19453/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3219367
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@qliphy @perrotta , this just adds extra unit tests for pytest and anyio. Feel free to merge it

@qliphy
Copy link
Contributor

qliphy commented Oct 10, 2021

merge

@cmsbuild cmsbuild merged commit 5561cd5 into master Oct 10, 2021
@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants