Make the CUDA/SoA pixel clusterizer use the same thresholds as the legacy module [12.0.x]

[fwyzard]

PR description:

Make the CUDA/SoA pixel clusterizer use the same thresholds as the legacy module.
This allows for changes like those in #35518 to be picked up transparently by the CUDA/SoA modules.

In addition, make the legacy pixel channel threshold coherent with the value used in the gpu module.

PR validation:

Checked that modifications to the parameters in the legacy modules propagate to the CUDA/SoA modules.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport #35570 with additional changes.

[fwyzard]

enable gpu

[fwyzard]

please test

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_12_0_X.

It involves the following packages:

• HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[fwyzard]

This PR may or may not be needed, depending if and how #35518 is backported to 12.0.x .

[missirol]

please abort

I don't see the tests running, trying to restart them.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5d1eb3/19475/summary.html
COMMIT: 57d0e59
CMSSW: CMSSW_12_0_X_2021-10-07-1100/slc7_amd64_gcc900
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35571/19475/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 4
• DQMHistoTests: Total histograms compared: 19735
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 19729
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
• Checked 12 log files, 9 edm output root files, 4 DQM output files
• TriggerResults: no differences found

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998542
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[missirol]

@fwyzard, for the purpose of the Patatrack customisations, these changes look okay to me even if #35518 is not backported to 12.0.x. Do you confirm?

[fwyzard]

for the purpose of the Patatrack customisations, these changes look okay to me even if #35518 is not backported to 12.0.x. Do you confirm?

Yes, exactly:

• if Increase SiPixel L1 cluster threshold from 2000 to 4000e, synchronize channel threshold between HTL and offline #35518 is not backported, this PR is OK;
• if Increase SiPixel L1 cluster threshold from 2000 to 4000e, synchronize channel threshold between HTL and offline #35518 is later backported, this PR makes those changes transparent for the Patatrack customisation as well.

[missirol]

+hlt

• backport of #35570 + plus a customisation (only in customizeHLTforPatatrack) of one param of the legacy pixel local reco for better consistency between CPU and GPU modules (the legacy parameter was incorrect at HLT, and will be fixed in 12.1.x HLT menus; see #35518 and links therein)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1