Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GCC11 header consistency errors #35573

Merged
merged 2 commits into from Oct 8, 2021
Merged

Conversation

smuzaffar
Copy link
Contributor

With GCC11 we get few header consistency errors [a]. This PR includes the missing headers to fix these.

[a]

src/DataFormats/Common/interface/IDVectorMap.h:195:5: error: 'size_t' does not name a type
src/DataFormats/Common/interface/getThinned_implementation.h:21:66: error: 'numeric_limits' is not a member of 'std'
src/DataFormats/Common/interface/getThinned_implementation.h:21:81: error: expected primary-expression before 'unsigned'
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:18:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:19:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:20:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:21:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:22:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:24:20: error: 'ee_fCPerMIP' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:25:15: error: 'ee_cce' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:26:20: error: 'ee_noise_fC' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:27:17: error: 'ee_rcorr' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:28:19: error: 'ee_weights' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:40:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:41:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:42:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:43:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:44:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:46:20: error: 'hef_fCPerMIP' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:47:15: error: 'hef_cce' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:48:20: error: 'hef_noise_fC' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:49:17: error: 'hef_rcorr' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:50:19: error: 'hef_weights' was not declared in this scope
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:63:20: error: 'size_t' does not name a type
src/CUDADataFormats/HGCal/interface/HGCUncalibRecHitsToRecHitsConstants.h:65:19: error: 'heb_weights' was not declared in this scope

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35573/25817

  • This PR adds an extra 24KB to repository

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • CUDADataFormats/HGCal (heterogeneous, upgrade, reconstruction)
  • DataFormats/Common (core)

@smuzaffar, @Dr15Jones, @makortel, @slava77, @AdrianoDee, @srimanob, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@makortel, @rovere, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-87dc23/19470/summary.html
COMMIT: b95c586
CMSSW: CMSSW_12_1_X_2021-10-07-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35573/19470/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 3219394
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3219366
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 169 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor

makortel commented Oct 7, 2021

+core

@makortel
Copy link
Contributor

makortel commented Oct 7, 2021

+heterogeneous

@jpata
Copy link
Contributor

jpata commented Oct 8, 2021

+reconstruction

  • technical, no reco changes

@srimanob
Copy link
Contributor

srimanob commented Oct 8, 2021

+Upgrade

Technical PRs, no change is expected.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Oct 8, 2021

+1

@cmsbuild cmsbuild merged commit 91d1e8b into cms-sw:master Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants