Run3-alca206 Add a few more variables to HcalHBHEMuonVariables to analyze alternative Hcal Reco schemes #35587

bsunanda · 2021-10-08T13:32:03Z

PR description:

Add a few more variables to HcalHBHEMuonVariables to analyze alternative Hcal Reco schemes

PR validation:

Use the cfg files in the test directories of Calibration/Hcal...

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

…ive Hcal Reco schemes

cmsbuild · 2021-10-08T13:39:02Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25833

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25833/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25833/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-10-08T13:49:19Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25835

This PR adds an extra 32KB to repository

cmsbuild · 2021-10-08T13:49:57Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/HcalAlCaRecoProducers (alca)
Calibration/HcalCalibAlgos (alca)
DataFormats/HcalCalibObjects (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @abdoulline, @rovere, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

tvami · 2021-10-08T13:50:07Z

Calibration/HcalAlCaRecoProducers/plugins/AlCaHcalHBHEMuonFilter.cc

      labelHBHEMuonVar_(iConfig.getParameter<edm::InputTag>("hbheMuonLabel")),
      tokHBHEMuonVar_(consumes<HcalHBHEMuonVariablesCollection>(labelHBHEMuonVar_)) {
-  edm::LogVerbatim("HBHEMuon") << "Parameters read from config file \n\t prescale_ " << prescale_ << "\n\t Labels "
-                               << labelHBHEMuonVar_;
+  edm::LogVerbatim("HBHEMuon") << "Parameters read from config file \n\t prescale " << prescale_ << "\t minimumMuonP "


Suggested change

edm::LogVerbatim("HBHEMuon") << "Parameters read from config file \n\t prescale " << prescale_ << "\t minimumMuonP "

edm::LogVerbatim("HBHEMuon") << "Parameters read from config file \n\t prescale " << prescale_ << "\t minimumMuonP_ "

cmsbuild · 2021-10-08T14:07:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25839

This PR adds an extra 32KB to repository

cmsbuild · 2021-10-08T14:07:53Z

Pull request #35587 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

tvami · 2021-10-08T14:08:00Z

@cmsbuild , please test

cmsbuild · 2021-10-08T18:18:06Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b53c6/19498/summary.html
COMMIT: 06a4ae5
CMSSW: CMSSW_12_1_X_2021-10-07-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35587/19498/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 3219394
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 3219360
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-10-09T00:12:48Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25852

This PR adds an extra 32KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25852/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25852/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-10-09T00:27:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35587/25853

This PR adds an extra 36KB to repository

cmsbuild · 2021-10-09T00:28:10Z

Pull request #35587 was updated. @cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

bsunanda · 2021-10-09T00:28:44Z

@cmsbuild Please test

cmsbuild · 2021-10-09T04:03:13Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b53c6/19510/summary.html
COMMIT: e878741
CMSSW: CMSSW_12_1_X_2021-10-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35587/19510/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2798082
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2798053
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

tvami · 2021-10-09T14:16:05Z

+alca

cmsbuild · 2021-10-09T14:16:23Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-10-10T00:39:52Z

+1

Add a few more variables to HcalHBHEMuonVariables to analyze alternat…

49dd9fe

…ive Hcal Reco schemes

cmsbuild added this to the CMSSW_12_1_X milestone Oct 8, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Oct 8, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 8, 2021

Code check

7cf7401

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 8, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 8, 2021

tvami reviewed Oct 8, 2021

View reviewed changes

Use Tamas's suggestion

06a4ae5

cmsbuild added code-checks-pending and removed code-checks-approved labels Oct 8, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 8, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 8, 2021

cmsbuild removed the tests-started label Oct 8, 2021

cmsbuild added pending-signatures tests-pending labels Oct 9, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 9, 2021

Change of name

3b23255

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 9, 2021

Code check

e878741

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 9, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 9, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Oct 9, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 10, 2021

cmsbuild merged commit 1c40f80 into cms-sw:master Oct 10, 2021

cmsbuild mentioned this pull request Oct 12, 2021

rootmodule: Updated root to tip of branch master cms-sw/cmsdist#7382

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca206 Add a few more variables to HcalHBHEMuonVariables to analyze alternative Hcal Reco schemes #35587

Run3-alca206 Add a few more variables to HcalHBHEMuonVariables to analyze alternative Hcal Reco schemes #35587

bsunanda commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

tvami Oct 8, 2021

cmsbuild commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

tvami commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

cmsbuild commented Oct 9, 2021

cmsbuild commented Oct 9, 2021

cmsbuild commented Oct 9, 2021

bsunanda commented Oct 9, 2021

cmsbuild commented Oct 9, 2021

tvami commented Oct 9, 2021

cmsbuild commented Oct 9, 2021

qliphy commented Oct 10, 2021

	edm::LogVerbatim("HBHEMuon") << "Parameters read from config file \n\t prescale " << prescale_ << "\t minimumMuonP "
	edm::LogVerbatim("HBHEMuon") << "Parameters read from config file \n\t prescale " << prescale_ << "\t minimumMuonP_ "

Run3-alca206 Add a few more variables to HcalHBHEMuonVariables to analyze alternative Hcal Reco schemes #35587

Run3-alca206 Add a few more variables to HcalHBHEMuonVariables to analyze alternative Hcal Reco schemes #35587

Conversation

bsunanda commented Oct 8, 2021

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

tvami Oct 8, 2021

Choose a reason for hiding this comment

cmsbuild commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

tvami commented Oct 8, 2021

cmsbuild commented Oct 8, 2021

Comparison Summary

cmsbuild commented Oct 9, 2021

cmsbuild commented Oct 9, 2021

cmsbuild commented Oct 9, 2021

bsunanda commented Oct 9, 2021

cmsbuild commented Oct 9, 2021

Comparison Summary

tvami commented Oct 9, 2021

cmsbuild commented Oct 9, 2021

qliphy commented Oct 10, 2021