Undo update of Run-3 GTs in autoCondHLT

[missirol]

PR description:

This PR reverts #35207, as that now conflicts with #35593 (see #35593 (comment)).

Keeping it as draft PR until @Martin-Grunewald can review.

PR validation:

No errors after running addOnTests.py --tests=hlt_data_GRun with #35593.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35600/25864

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• Configuration/HLT (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[tvami]

Should this be tested together with #35593 ?

[missirol]

I first wanted to test this without #35593. In parallel, the latter can test with this one.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c153a/19522/summary.html
COMMIT: 6910f93
CMSSW: CMSSW_12_1_X_2021-10-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35600/19522/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3019 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2798082
• DQMHistoTests: Total failures: 5721
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2792338
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 39 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: found differences in 1 / 39 workflows

[missirol]

Differences in wf 11634.911 are not likely to be related to these changes. I don't know the reason, but this reminded me of #32963.

[tvami]

It must be some temporary glitch, our AlCa PR tested with this is very clean:
#35593 (comment)

[Martin-Grunewald]

Sorry, why do we need this (rather than adding missing ES modules)?

[missirol]

IIuc.. the error in #35593 is related to an update of the Run-3 Prompt/Offline GT to use tag EcalLaserAPDPNRatios_prompt_v3, which contains only 1 payload, and no IOVs for Run-2 (see here). When the addOnTests run the RECO step with this GT, the fwk complains because the input is Run-2 data. If so, I guess adding an ES module cannot solve this.

Worth noting that this updated tag was not included in the Run-3 HLT GT, and in fact the HLT-only step of the addOnTests would still work even without this PR (this can be seen in the first tests of #35593).

AlCa experts may correct me, of course.

[francescobrivio]

IIuc.. the error in #35593 is related to an update of the Run-3 Prompt/Offline GT to use tag EcalLaserAPDPNRatios_prompt_v3, which contains only 1 payload, and no IOVs for Run-2 (see here). When the addOnTests run the RECO step with this GT, the fwk complains because the input is Run-2 data. If so, I guess adding an ES module cannot solve this.

Worth noting that this updated tag was not included in the Run-3 HLT GT, and in fact the HLT-only step of the addOnTests would still work even without this PR (this can be seen in the first tests of #35593).

AlCa experts may correct me, of course.

@missirol that is correct, only the EcalLaserAPDPNRatios_prompt_v3 tag in the prompt GT has been split between run2/run3 because it contained more than 50k IOVs and it had become hardly manageable. For the Express and HLT GT case there was no such need as the EcalLaser tags used there are different.

@Martin-Grunewald the new tag in the Prompt GT is fine for runs > 342663. Maybe we can update the hlt tests to use a more recent run (sorry I'm not sure how the tests are configured actually) ?

[Martin-Grunewald]

Which data taking period is runs > 342663?

[francescobrivio]

Which data taking period is runs > 342663?

@Martin-Grunewald sorry the run is actually 342670 (OMS link) which is the first run of CRUZET2021.

[Martin-Grunewald]

Hmm, we'd need some collision data, so then it looks like we need to reverse the old PR indeed and go back to run2 GTs as in this PR.

[missirol]

Thanks Martin (and Francesco). Agreed. I will then go ahead and sign this.

[missirol]

+hlt

• reverts #35207 to allow integration of #35593, and comply with #35593 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1