Better handling of strings in ExternalGeneratorFilter [10_6]

[Dr15Jones]

PR description:

Now handle case where strings have embedded \n which must be properly propagated to the external workers.
This was uncovered when I tried to convert an inefficient GEN job to use ExternalGeneratorFilter and it failed to parse.

PR validation:

A previously failing configuration now runs.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_10_6_X.

It involves the following packages:

• GeneratorInterface/Core (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Better string handling ExternalGeneratorFilter #35611

[Dr15Jones]

please test

[cmsbuild]

Pull request #35610 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @agrohsje, @alberto-sanchez can you please check and sign again.

[Dr15Jones]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d31ae4/19565/summary.html
COMMIT: b530c8f
CMSSW: CMSSW_10_6_X_2021-10-10-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35610/19565/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1072 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 2153
• DQMHistoTests: Total nulls: 105
• DQMHistoTests: Total successes: 3213094
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -81.002 KiB( 34 files compared)
• DQMHistoSizes: changed ( 140.53 ): -63.680 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -15.641 KiB Info/EventInfo
• DQMHistoSizes: changed ( 140.53 ): -1.676 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 140.53 ): -0.006 KiB SiStrip/MechanicalView
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[qliphy]

backport of #35611

[SiewYan]

please test workflow 140.53

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d31ae4/19617/summary.html
COMMIT: b530c8f
CMSSW: CMSSW_10_6_X_2021-10-13-2300/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35610/19617/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 143 log files, 29 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[qliphy]

@cms-sw/generators-l2 Any comment?

[SiewYan]

Its look good now!

[SiewYan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

backport of #35611

[qliphy]

+1