Updates towards enabling deepTauID at HLT #35619

mbluj · 2021-10-12T08:53:29Z

PR description:

This PR contains a set of changes needed to enable deepTauID at HLT:

Producer of PFTaus matched to L1 seeds (L1THLTTauMatching) updated to produce (depending on a python configuration argument) either PFTaus with all data members filled for further processing or "empty" PFTaus with only p4 and vertex information filled which is minimal information needed for filtering;
Added simpler (a more user-friendly) approach to define working points in deepTauBase;
Define default output values if a preselection in the deepTauID producer fails;
PFTauSelectorDefinition updated to handle outputs from the DeepTauID module and thus allow for filtering on deepTauID output;
The deepTauAtHLT.py customisation file updated to simulate a full di-tau paths with deepTauID for measurements needed before integration with an actual HLT menu. Module names in the customisation file adapted to not cause unwanted overlap with other paths/sequences; Implemented proper deepTauID working points for HLT which are a function of tau pt.

The PR is targeting 12_1_0 to allow tests and then integration with HLT for Run3.

PR validation:

The PR has been validated on top of 12_1_0_pre4:

DeepTauID modules have been run both for offline and online (with the two customisation functions) and run smoothly without unexpected surprises in the output. Results with standard workflows containing deepTauID (miniAOD) are expected to not change.
The following command has been run to perform tests, which all succeeded:

scram b distclean 
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
runTheMatrix.py -l limited -i all --ibeos

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

cmsbuild · 2021-10-12T09:00:15Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35619/25891

This PR adds an extra 120KB to repository
Found files with invalid states:
- RecoTauTag/RecoTau/plugins/CounterFilter.cc:
  - Added: 09b1436
  - Deleted: 0377c20
- RecoTauTag/RecoTau/interface/CounterTuple.h:
  - Added: 09b1436
  - Deleted: 0377c20

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35619/25891/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35619/25891/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-10-12T09:21:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35619/25892

This PR adds an extra 212KB to repository
Found files with invalid states:
- RecoTauTag/RecoTau/plugins/CounterFilter.cc:
  - Added: 0abc352
  - Deleted: 057fb84
- RecoTauTag/RecoTau/interface/CounterTuple.h:
  - Added: 0abc352
  - Deleted: 057fb84

cmsbuild · 2021-10-12T09:21:39Z

A new Pull Request was created by @mbluj for master.

It involves the following packages:

RecoTauTag/HLTProducers (hlt)
RecoTauTag/RecoTau (reconstruction)

@jpata, @missirol, @cmsbuild, @Martin-Grunewald, @slava77 can you please review it and eventually sign? Thanks.
@silviodonato, @mbluj, @swozniewski this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2021-10-12T10:08:45Z

please test

RecoTauTag/HLTProducers/src/L1THLTTauMatching.cc

RecoTauTag/RecoTau/plugins/DeepTauId.cc

missirol · 2021-10-12T10:20:37Z

@mbluj I left a couple of style suggestions inline.
I would suggest to squash the commits into one, to tidy up the history.

RecoTauTag/HLTProducers/python/deepTauAtHLT_30GeV.py

RecoTauTag/HLTProducers/python/deepTauAtHLT_35GeV.py

RecoTauTag/RecoTau/plugins/PFTauSelectorDefinition.h

cmsbuild · 2021-10-12T19:20:51Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d694b0/19562/summary.html
COMMIT: 3a1f7a2
CMSSW: CMSSW_12_1_X_2021-10-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35619/19562/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2798082
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2798053
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 169 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

mbluj · 2021-10-13T10:33:50Z

@missirol - thank you for comments - I plan to work on them today. Concerning squashing the commits into one - I am not fan of this as tidying history means losing history. I can try to clear the history a bit, but I do not see big advantage of it.

cmsbuild · 2021-10-18T08:48:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35619/26022

This PR adds an extra 12KB to repository
Found files with invalid states:
- RecoTauTag/HLTProducers/python/deepTauAtHLT_35GeV.py:
  - Added: f5c9b43
  - Modified: c48ceb0
  - Deleted: 5644094
- RecoTauTag/HLTProducers/python/deepTauAtHLT.py:
  - Modified: 3746657, b13a1b3
  - Deleted: f5c9b43
  - Added: 5644094
- RecoTauTag/HLTProducers/python/deepTauAtHLT_30GeV.py:
  - Added: f5c9b43
  - Modified: c48ceb0
  - Deleted: 5644094
- RecoTauTag/RecoTau/plugins/CounterFilter.cc:
  - Added: 3746657
  - Deleted: f5c9b43
- RecoTauTag/RecoTau/interface/CounterTuple.h:
  - Added: 3746657
  - Deleted: f5c9b43

cmsbuild · 2021-10-18T08:49:14Z

Pull request #35619 was updated. @jpata, @missirol, @cmsbuild, @Martin-Grunewald, @slava77 can you please check and sign again.

perrotta · 2021-10-18T10:19:47Z

please test

cmsbuild · 2021-10-18T13:43:43Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d694b0/19708/summary.html
COMMIT: b13a1b3
CMSSW: CMSSW_12_1_X_2021-10-17-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35619/19708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 8 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2751113
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2751085
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
Checked 170 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

slava77 · 2021-10-18T17:49:38Z

+reconstruction

for #35619 b13a1b3

code changes since the last reco signoff were outside of reco, in RecoTauTag/HLTProducers/python/deepTauAtHLT.py

missirol · 2021-10-18T18:25:49Z

+hlt

cmsbuild · 2021-10-18T18:26:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-10-18T20:49:55Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Oct 12, 2021

cmsbuild added code-checks-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 12, 2021

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 12, 2021

mbluj force-pushed the CMSSW_12_0_X_tau-pog_DeepTauAtHLT branch from 198cbe8 to 3a1f7a2 Compare October 12, 2021 09:12

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 12, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 12, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 12, 2021