Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case-sensitive ConfDb connection parameters - 106X #35647

Merged

Conversation

Martin-Grunewald
Copy link
Contributor

PR description:

Fix case-sensitive ConfDb password - 106X

PR validation:

TSG tests

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #33981

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 13, 2021

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_6_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #33981

@Martin-Grunewald
Copy link
Contributor Author

type bug-fix

@Martin-Grunewald
Copy link
Contributor Author

please test

@Martin-Grunewald Martin-Grunewald changed the title Fix case-sensitive ConfDb password - 106X Fix case-sensitive ConfDb connection parameters - 106X Oct 13, 2021
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41f5e6/19592/summary.html
COMMIT: a0da42d
CMSSW: CMSSW_10_6_X_2021-10-10-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35647/19592/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1072 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2153
  • DQMHistoTests: Total nulls: 105
  • DQMHistoTests: Total successes: 3213094
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -81.002 KiB( 34 files compared)
  • DQMHistoSizes: changed ( 140.53 ): -63.680 KiB Hcal/DigiRunHarvesting
  • DQMHistoSizes: changed ( 140.53 ): -15.641 KiB Info/EventInfo
  • DQMHistoSizes: changed ( 140.53 ): -1.676 KiB RPC/DCSInfo
  • DQMHistoSizes: changed ( 140.53 ): -0.006 KiB SiStrip/MechanicalView
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@Martin-Grunewald
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Oct 13, 2021

+1

@cmsbuild cmsbuild merged commit 81f8ed6 into cms-sw:CMSSW_10_6_X Oct 13, 2021
@Martin-Grunewald Martin-Grunewald deleted the FixCaseSensitiveConfDbPassword106X branch October 27, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants