Enable mkFit by default in 4+2 tracking iterations (initialStepPreSpl…

[mmasciov]

PR description:

Following PR #35457, this PR enables mkFit for tracking in 4 (initialStepPreSplitting, initialStep, highPtTripletStep, detachedQuadStep) + 2 (detachedTripletStep, pixelLessStep) tracking iterations for the entire era of Phase-1 pixel detector (i.e. from 2017 to end of Run 3), except for HI eras (Run2_2017_pp_on_XeXe, Run2_2017_ppRef, Run2_2018_pp_on_AA, Run2_2018_pp_on_AA_noHCALmitigation, Run3_pp_on_PbPb) and 2017 special tracking eras (Run2_2017_trackingLowPU, Run2_2017_trackingRun2), following the plan presented in https://indico.cern.ch/event/1082441/#1-news

Note: the first 4 iterations were already enabled in PR #35457; this PR enables 2 additional iterations.

PR validation:

The performance of tracking after this PR, together with PR #35652 and PR #35686 (updated as suggested here) follows:
http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/PRvalidation_Oct13/MTV_PR35660_mkFit-6iter_DNNfinalWP_afterPR35652/
Looking at out-of-the-box high-purity tracks (http://uaf-10.t2.ucsd.edu/~mmasciov/MkFit_devs/PRvalidation_Oct13/MTV_PR35660_mkFit-6iter_DNNfinalWP_afterPR35652/plots_highPurity/effandfakePtEtaPhi.pdf), efficiency is (much) improved (at low track pT), with overall lower fake+duplicate rate.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35660/25930

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @mmasciov (Mario Masciovecchio) for master.

It involves the following packages:

• Configuration/Eras (operations)

@cmsbuild, @perrotta, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @missirol, @fabiocos, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[makortel]

@cms-sw/reconstruction-l2 Should reco sign this?

[makortel]

Also FYI @cms-sw/tracking-pog-l2

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-90ee4c/19615/summary.html
COMMIT: 70bb244
CMSSW: CMSSW_12_1_X_2021-10-13-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35660/19615/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 23695 lines to the logs
• Reco comparison results: 20461 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2796107
• DQMHistoTests: Total failures: 37743
• DQMHistoTests: Total nulls: 7
• DQMHistoTests: Total successes: 2758335
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.07 KiB( 39 files compared)
• DQMHistoSizes: changed ( 136.793 ): 0.066 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 136.874 ): 0.008 KiB JetMET/SUSYDQM
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 169 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[perrotta]

assign reconstruction

[cmsbuild]

New categories assigned: reconstruction

@slava77,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

[jpata]

Could you link a presentation in the description where the tracking performance (and if possible, also downstream performance) of just this PR is shown?

The current link in the description is to the PPD news / plans, where the effect of just these two additional iterations is not clear to me.

[mmasciov]

Could you link a presentation in the description where the tracking performance (and if possible, also downstream performance) of just this PR is shown?

The current link in the description is to the PPD news / plans, where the effect of just these two additional iterations is not clear to me.

@jpata, the description of the PR has been updated as requested, with MTV results showing that tracking performance after this PR (together with PR #35652 and updated PR #35686) is largely improved.
Further physics validation will anyways be performed using directly 12_1_0_pre5, as agreed with PPD.

[jpata]

+reconstruction

• enables mkFit in two additional iterations by default
• reco changes expected in all downstream quantities from tracks (summarized in the description)

[perrotta]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.