PPS bug fix of Run2 pixel topology

[fabferro]

PR description:

This PR fix a couple of missing parameters in the Run2 configuration of PPS Pixel topology

PR validation:

Direct simulation tests and reconstruction ones are ok.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35671/25958

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @fabferro (Fabrizio Ferro) for master.

It involves the following packages:

• CalibPPS/ESProducers (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @jan-kaspar, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

type bug-fix

[tvami]

@cmsbuild , please test

[fabferro]

@jan-kaspar FYI

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c9f52/19627/summary.html
COMMIT: 1182205
CMSSW: CMSSW_12_1_X_2021-10-14-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35671/19627/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @atishelmanch Proposed solution to ECAL emulator PR issue  #35557
• @CMSTrackerDPG Prompt calibration loop module for SiPixelLorentzAngle #35507
• @ChrisMisan Diamond sampic dqm #35445

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c9f52/19627/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8c9f52/19627/git-merge-result

Comparison Summary

The workflows 1001.0 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 22 differences found in the comparisons
• DQMHistoTests: Total files compared: 40
• DQMHistoTests: Total histograms compared: 2768870
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2768842
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -10588.948 KiB( 38 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): -3151.653 KiB CTPPS/TimingFastSilicon
• DQMHistoSizes: changed ( 10024.0,... ): 2360.820 KiB CTPPS/DiamondSampic
• DQMHistoSizes: changed ( 11634.0,... ): 2441.273 KiB CTPPS/DiamondSampic
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 40 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• tests pass ok, diff only in MsgLogger

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Differences in outputs are due to Diamond sampic dqm #35445, which is run together and removes totemTimingLocalTracker