New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix default SPLASH settings (FP) #35715
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35715/26030
|
A new Pull Request was created by @pmandrik for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ebb182/19716/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@@ -29,7 +29,7 @@ | |||
|
|||
if not unitTest : | |||
if options.BeamSplashRun : | |||
# scenarioName = 'ppEra_Run3' FIXME | |||
scenarioName = 'ppEra_Run3' | |||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the previous line gets un-commented, this pass
statement is not needed any more. It also doesn't hurt, though...
@@ -29,7 +29,7 @@ | |||
|
|||
if not unitTest : | |||
if options.BeamSplashRun : | |||
# scenarioName = 'ppEra_Run3' #FIXME | |||
scenarioName = 'ppEra_Run3' | |||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the previous line gets un-commented, this pass
statement is not needed any more. It also doesn't hurt, though...
+1 |
PR description:
for ED clients add tested default run type SPLASH settings
add some useful printouts for beam, beamhlt & beamspotdip clients
PR validation:
Forward port of 35688