Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete Digi collections #35738

Merged
merged 2 commits into from Oct 27, 2021

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Oct 20, 2021

PR description:

Remove some obsolete HGCAL Digi collections that are no longer needed.
Expect no regression.

PR validation:

Limited Matrix runs smoothly.

@rovere
Copy link
Contributor Author

rovere commented Oct 20, 2021

assign hgcal-dpg

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35738/26081

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

New categories assigned: hgcal-dpg

@felicepantaleo,@rovere,@pfs,@cseez you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • DataFormats/HGCDigi (upgrade, simulation)
  • EventFilter/HGCalRawToDigi (upgrade, reconstruction)
  • L1Trigger/L1THGCal (upgrade, l1)
  • SimCalorimetry/HGCalSimProducers (upgrade, simulation)

@pfs, @perrotta, @civanch, @rekovic, @felicepantaleo, @mdhildreth, @cecilecaillol, @cmsbuild, @AdrianoDee, @srimanob, @cseez, @rovere, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@cseez, @vandreev11, @sethzenz, @missirol, @makortel, @lgray, @Martin-Grunewald, @apsallid, @bsunanda, @pfs, @hatakeyamak, @amarini, @fabiocos, @jbsauvan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Oct 20, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-617e8a/19757/summary.html
COMMIT: b818efc
CMSSW: CMSSW_12_1_X_2021-10-19-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35738/19757/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 40
  • DQMHistoTests: Total histograms compared: 2751113
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2751086
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 39 files compared)
  • Checked 170 log files, 37 edm output root files, 40 DQM output files
  • TriggerResults: no differences found

@rovere
Copy link
Contributor Author

rovere commented Oct 20, 2021

Failures are unrelated to this work and limited to usually non-reproducible histograms.

@rovere
Copy link
Contributor Author

rovere commented Oct 21, 2021

+1

@AdrianoDee
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Oct 21, 2021

+1

@slava77
Copy link
Contributor

slava77 commented Oct 22, 2021

+reconstruction

for #35738 b818efc

  • code changes are technical, in line with the PR description
  • jenkins tests pass

@rovere
Copy link
Contributor Author

rovere commented Oct 22, 2021

ping l1

@rovere
Copy link
Contributor Author

rovere commented Oct 22, 2021

ping operation

@rekovic
Copy link
Contributor

rekovic commented Oct 26, 2021

+1

@perrotta
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa163d7 into cms-sw:master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants