[12.0.X] Improve logging of BeamSpot DQM clients

[francescobrivio]

PR description:

Improves the logging of the BeamSpot DQM clients by printing also the Run number at the beginning of the luminosity block, not only the lumi number.

PR validation:

Code compiles plus validated with the unittest:
cmsRun DQM/Integration/python/clients/beamfake_dqm_sourceclient-live_cfg.py unitTest=True
The output of the log changes from:
[2021-10-20 10:14:00.539860] INFO: FakeBeamMonitor::beginLuminosityBlock - LS: 1
to
[2021-10-20 12:30:26.825302] INFO: FakeBeamMonitor::beginLuminosityBlock - LS: 1 - Run: 344518

Backport:

Backport of #35749

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_12_0_X.

It involves the following packages:

• DQM/BeamMonitor (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Improve logging of BeamSpot DQM clients #35749

[francescobrivio]

@ahmad3213 @pmandrik please test this with a playback in P5 at your convenience, this should then be applied on top of the current release. This is not critical for data-taking, but would be of great help in debugging the BeamSpot clients.

FYI @gennai @mzarucki this would be very helpful for the next run testing the collision menu I think.

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cf275/19764/summary.html
COMMIT: e096ad4
CMSSW: CMSSW_12_0_X_2021-10-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35743/19764/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2998536
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

test parameters:

• addpkg = DQM/Integration

[jfernan2]

please test
Even if it was tested privately the unitTest, let's check it does not break it "officially"

[francescobrivio]

backport of #35749

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cf275/19775/summary.html
COMMIT: e096ad4
CMSSW: CMSSW_12_0_X_2021-10-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35743/19775/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2998542
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1
Tested in Online DQM at P5

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[francescobrivio]

@qliphy @perrotta please consider merging this asap because once it is merged it can be applied online in DQM machines on top of the current release. It would be useful to have it before the next time the HLT collision menu is tested.
Anyway this has only effect on logging for debugging and not on actual data taking.

[qliphy]

+1

[francescobrivio]

Thanks @qliphy!

@pmandrik @ahmad3213 this is now merged both in 12_0_X and in master, so please consider adding this PR on top of the release in P5 DQM machines before the HLT collision menu is tested again.

FYI @gennai @mzarucki