Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrent lumi usage in DQMStore [12_0] #35752

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Avoid deleting the MonitorElement meta data for localMEs.
Backport of #35751.

PR validation:

Code compiles and simple job which was failing before now succeeds. Also varified with valgrind.

Avoid deleting the MonitorElement meta data for localMEs
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 20, 2021

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_12_0_X.

It involves the following packages:

  • DQMServices/Core (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

Backport of #35751

@Dr15Jones
Copy link
Contributor Author

please test

@tvami
Copy link
Contributor

tvami commented Oct 20, 2021

type bug-fix

@tvami
Copy link
Contributor

tvami commented Oct 20, 2021

urgent

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98ca7b/19779/summary.html
COMMIT: 993b388
CMSSW: CMSSW_12_0_X_2021-10-19-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35752/19779/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@Dr15Jones
Copy link
Contributor Author

hold
#35757 does the same work

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Oct 21, 2021
@perrotta
Copy link
Contributor

@Dr15Jones now that #35757 is merged in 12_0, can we close this (to clean up the queue)?

@Dr15Jones
Copy link
Contributor Author

superseded by #35757

@Dr15Jones Dr15Jones closed this Oct 22, 2021
@Dr15Jones Dr15Jones deleted the fixDQMServiceConcurrentLumis_12_0 branch October 22, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants