Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

71 x merge 70 x pre mixing 4 29 #3576

Merged

Conversation

mdhildreth
Copy link
Contributor

Merge of PreMixing from 70X changes onto 71X. Recovering from failure of auto-forward-port from last week. Merged onto latest IB.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mdhildreth for CMSSW_7_1_X.

71 x merge 70 x pre mixing 4 29

It involves the following packages:

Configuration/Applications
Configuration/EventContent
Configuration/StandardSequences
SimCalorimetry/CaloSimAlgos
SimCalorimetry/EcalSimAlgos
SimCalorimetry/EcalSimProducers
SimCalorimetry/HcalSimAlgos
SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalTestBeam
SimGeneral/DataMixingModule
SimGeneral/MixingModule

@civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @wmtan, @GiacomoSguazzoni, @rovere, @argiro, @cerati this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mdhildreth
Copy link
Contributor Author

+1

@davidlange6
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
There is a std::cout in the diff for this pull request. Could you please clean it up?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Apr 30, 2014

At least in this case, this is legitimate complain. Mike can you clean up the cout and and the commented code? Thanks.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

Pull request #3576 was updated. @civanch, @nclopezo, @vlimant, @mdhildreth, @cmsbuild, @franzoni, @Degano, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

-1
I ran the usual tests and I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3576/1254/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2014

@davidlange6
Copy link
Contributor

+1
for operations - I don't think the errors had anything to do with this PR did they?
@mdhildreth - can you sign for sim?

@civanch
Copy link
Contributor

civanch commented May 6, 2014

+1
I hope Mike agree

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request May 7, 2014
@davidlange6 davidlange6 merged commit 1fac653 into cms-sw:CMSSW_7_1_X May 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants