default initialize TrajectorySeed::dir_ #35795

slava77 · 2021-10-23T01:48:15Z

this is following the UBSAN issue reported in #35033

138.2 step2
DataFormats/TrajectorySeed/interface/TrajectorySeed.h:44:3: runtime error: 
      load of value 10967, which is not a valid value for type 'PropagationDirection'

cmsbuild · 2021-10-23T01:57:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35795/26159

This PR adds an extra 12KB to repository

cmsbuild · 2021-10-23T01:58:15Z

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

DataFormats/TrajectorySeed (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@JanFSchulte, @rovere, @VinInn, @gpetruc, @mmusich, @mtosi this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2021-10-23T02:05:01Z

@cmsbuild please test

cmsbuild · 2021-10-23T10:32:38Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52af3e/19857/summary.html
COMMIT: 71533e0
CMSSW: CMSSW_12_1_X_2021-10-22-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35795/19857/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52af3e/19857/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52af3e/19857/git-merge-result

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2751113
DQMHistoTests: Total failures: 13
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2751077
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 170 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

VinInn · 2021-10-23T13:00:14Z

DataFormats/TrajectorySeed/interface/TrajectorySeed.h

@@ -59,7 +59,7 @@ class TrajectorySeed {
 private:
  RecHitContainer hits_;
  PTrajectoryStateOnDet tsos_;
-  PropagationDirection dir_;
+  PropagationDirection dir_ = oppositeToMomentum;  // = 0


why oppositeToMomentum?

why oppositeToMomentum?

because its int value is 0 and that's what's the most likely "empty" memory default is.

Sorry I do not find this argument convincing.
Either it is left uninitialized (and the cause fixed) or it shall be initialized to a "invalid" value eventually extending the corresponding enum

Either it is left uninitialized (and the cause fixed) or it shall be initialized to a "invalid" value eventually extending the corresponding enum

fair enough. I've extended the enum.

cmsbuild · 2021-10-24T16:13:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35795/26174

This PR adds an extra 16KB to repository

cmsbuild · 2021-10-24T16:13:46Z

Pull request #35795 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2021-10-24T16:19:34Z

@cmsbuild please test

cmsbuild · 2021-10-24T20:54:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52af3e/19878/summary.html
COMMIT: 92f1195
CMSSW: CMSSW_12_1_X_2021-10-24-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35795/19878/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 40
DQMHistoTests: Total histograms compared: 2751113
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2751084
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 39 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 170 log files, 37 edm output root files, 40 DQM output files
TriggerResults: no differences found

slava77 · 2021-10-26T12:48:46Z

+reconstruction

for #35795 92f1195

jenkins tests pass and comparisons with the baseline show no relevant differences, which confirms that the PR is essentially technical

cmsbuild · 2021-10-26T12:49:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2021-10-26T13:19:10Z

+1

default initialize TrajectorySeed::dir_

71533e0

cmsbuild added this to the CMSSW_12_1_X milestone Oct 23, 2021

cmsbuild added code-checks-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 23, 2021

slava77 mentioned this pull request Oct 23, 2021

[UBSAN] Undefined behavior in DataFormats/* reco packages #35033

Open

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 23, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 23, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 23, 2021

VinInn reviewed Oct 23, 2021

View reviewed changes

add invalidDirection

61a6537

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Oct 24, 2021

default to invalidDirection

92f1195

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 24, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 24, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 24, 2021

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Oct 26, 2021

cmsbuild added orp-approved and removed orp-pending labels Oct 26, 2021

cmsbuild merged commit ce8cd4d into cms-sw:master Oct 26, 2021

cmsbuild mentioned this pull request Oct 27, 2021

default initialize HiPuRhoProducer::postOrphan_ #35857

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

default initialize TrajectorySeed::dir_ #35795

default initialize TrajectorySeed::dir_ #35795

slava77 commented Oct 23, 2021

cmsbuild commented Oct 23, 2021

cmsbuild commented Oct 23, 2021

slava77 commented Oct 23, 2021

cmsbuild commented Oct 23, 2021

VinInn Oct 23, 2021

slava77 Oct 23, 2021 •

edited

VinInn Oct 24, 2021

slava77 Oct 24, 2021

cmsbuild commented Oct 24, 2021

cmsbuild commented Oct 24, 2021

slava77 commented Oct 24, 2021

cmsbuild commented Oct 24, 2021

slava77 commented Oct 26, 2021

cmsbuild commented Oct 26, 2021

perrotta commented Oct 26, 2021

default initialize TrajectorySeed::dir_ #35795

default initialize TrajectorySeed::dir_ #35795

Conversation

slava77 commented Oct 23, 2021

cmsbuild commented Oct 23, 2021

cmsbuild commented Oct 23, 2021

slava77 commented Oct 23, 2021

cmsbuild commented Oct 23, 2021

Comparison Summary

VinInn Oct 23, 2021

Choose a reason for hiding this comment

slava77 Oct 23, 2021 • edited

Choose a reason for hiding this comment

VinInn Oct 24, 2021

Choose a reason for hiding this comment

slava77 Oct 24, 2021

Choose a reason for hiding this comment

cmsbuild commented Oct 24, 2021

cmsbuild commented Oct 24, 2021

slava77 commented Oct 24, 2021

cmsbuild commented Oct 24, 2021

Comparison Summary

slava77 commented Oct 26, 2021

cmsbuild commented Oct 26, 2021

perrotta commented Oct 26, 2021

slava77 Oct 23, 2021 •

edited