Made static const for BeamSpotTransientTrackingRecHit #3580
Conversation
By moving the initialization to library load time, the static used by BeamSpotTransientTrackingRecHit can be made const. This avoids thread-safety issues.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. Made static const for BeamSpotTransientTrackingRecHit It involves the following packages: Alignment/ReferenceTrajectories @cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks. |
|
+1 |
| isInitialized = true; | ||
| AlgebraicMatrix ret( 1, 5, 0); | ||
| ret[0][3] = 1; | ||
| return ret; | ||
| } |
There was a problem hiding this comment.
@Dr15Jones
Dummy question for my education. By declaring the initialize function as static, you make it visible only in this compilation unit, i.e. this library, right? This way, you can use it only in this file to initialise the instances you need.
But, IIRC, in order to mark a function as having internal linkage, so that it cannot be referenced in other compilation units, we can use anonymous namespaces in C++. Is there any reason for choosing one approach w.r.t. another?
There was a problem hiding this comment.
I'm still distrustful about how symbols are exported using anonymous namespaces. I'm probably just too old and set in my ways :).
…nsientTrackingRecHit Reco -- Made static const for BeamSpotTransientTrackingRecHit
By moving the initialization to library load time, the static used
by BeamSpotTransientTrackingRecHit can be made const. This avoids
thread-safety issues.