Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12_0_X] HCAL: switch off auxiliary M3 reconstruction fit for Run3 #35807

Merged
merged 3 commits into from Oct 26, 2021
Merged

[12_0_X] HCAL: switch off auxiliary M3 reconstruction fit for Run3 #35807

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0ba73bf
M3 switched off for Run3 in 12_0_X
Oct 24, 2021
b51d0e5
restore HLTEgPhaseIITestSequence_cff.py
Oct 25, 2021
2eaeae3
M3 off
Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions RecoEgamma/EgammaHLTProducers/python/HLTEgPhaseIITestSequence_cff.py
View file
Open in desktop
Expand Up @@ -2654,3 +2654,6 @@
PixelCPE = cms.string('PixelCPEGeneric'),
StripCPE = cms.string('StripCPEfromTrackAngle')
)

from Configuration.Eras.Modifier_run3_common_cff import run3_common
run3_common.toModify(hltHbhereco, algorithm = dict(useM3 = False))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HLT does not use Eras and anway has useM3 = cms.bool( False ) so this is not needed for HLT.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Martin-Grunewald thank you for calrification, I (naively) thought this might be a kind of standalone config used for some purposes. I've removed this modification.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I see that that file (PhaseII) actually sets useM3 = True which seems nonsensical but then it has to be switched to false after all. Apologies for the confusion!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwyzard

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Martin-Grunewald just to avoid any (more) confusion: do you suggest to bring the (just removed) customization back ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but also I want Andrea Bocci @fwyzard to clarify why in that Phase-II file useM3 = True is used.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay - this configuration is not used by the actual Phase-2 HLT menu (which anyway is not yet in 12.0.x/12.1.x...).
I don't know where it comes from, or if it used for anything - I guess only E/Gamma people can comment here.

4 changes: 2 additions & 2 deletions RecoLocalCalo/HcalRecProducers/python/HBHEPhase1Reconstructor_cfi.py
View file
Open in desktop
Expand Up @@ -112,5 +112,5 @@
from Configuration.Eras.Modifier_run2_HE_2017_cff import run2_HE_2017
run2_HE_2017.toModify(hbheprereco, saveEffectivePedestal = True)

from Configuration.Eras.Modifier_run3_HB_cff import run3_HB
run3_HB.toModify(hbheprereco, algorithm = dict(applyLegacyHBMCorrection = False))
from Configuration.Eras.Modifier_run3_common_cff import run3_common
run3_common.toModify(hbheprereco, algorithm = dict(applyLegacyHBMCorrection = False, useM3 = False))