`MonitorTrackResiduals`: do not apply PV compatibility cut when running cosmics [12.0.X] #35812

mmusich · 2021-10-24T16:02:48Z

backport of #35811

PR description:

I was casually looking at the Strip residuals in a CRAFT 2021 run but they don't make much sense e.g. the number of hits in TIB1 (https://tinyurl.com/yzwdcdc6) is less than BPIX1 (https://tinyurl.com/ygftohy4).
Also the Strip EndCap residuals plots are empty (https://tinyurl.com/ygxqol8b).
I strongly suspect this is due to the Primary Vertex compatibility cut at:

cmssw/DQM/TrackerMonitorTrack/src/MonitorTrackResiduals.cc

Line 251 in 6d2f660

    
           return track.pt() > 0.75 && abs(track.dxy(primaryVertex.position())) < 5 * track.dxyError();

that makes no sense in cosmic data-taking and is severely limiting the phase-space from which the cosmic tracks are considered (https://tinyurl.com/yjzgap6c)
The correct behavior is implemented instead in the Pixel residuals code:

cmssw/DQM/SiPixelPhase1Track/plugins/SiPixelPhase1TrackResiduals.cc

Lines 80 to 82 in c6d0025

    
             return (!applyVertexCut_ || 
        
                     (track.pt() > 0.75 && std::abs(track.dxy(vertices->at(0).position())) < 5 * track.dxyError())); 
        
           },

in which the PV compatibility cut is put in OR with a switch that is set to false in cosmics (and indeed the pixel residuals in cosmic runs are filled).
This PR implements the same mechanism also for Strip residuals.

No regression is expected for collision runs (pp or HI).

PR validation:

I've run workflow 138.2 (from 2021 cosmics commissioning, Run 343498) with 1000 events:

runTheMatrix.py -l 138.2 -j 8 --command='-n 1000'

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #35811

cmsbuild · 2021-10-24T16:03:15Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

DQM/SiStripMonitorClient (dqm)
DQM/TrackerMonitorTrack (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus, @venturia this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

Backported from MonitorTrackResiduals: do not apply PV compatibility cut when running cosmics #35811

mmusich · 2021-10-24T16:03:38Z

please test

mmusich · 2021-10-24T16:05:09Z

type bug-fix

tvami · 2021-10-24T18:12:46Z

urgent

let's make this into CMSSW_12_0_4 as well

cmsbuild · 2021-10-24T19:58:20Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be5abf/19877/summary.html
COMMIT: 73a5a16
CMSSW: CMSSW_12_0_X_2021-10-24-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35812/19877/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 62
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998479
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-10-25T07:05:50Z

+1

cmsbuild · 2021-10-25T07:06:12Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

mmusich · 2021-10-25T07:58:49Z

test parameters:

addpkg = DQM/Integration

mmusich · 2021-10-25T07:59:03Z

please test

… cosmics

cmsbuild · 2021-10-25T08:33:33Z

Pull request #35812 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

mmusich · 2021-10-25T08:35:21Z

please test

cmsbuild · 2021-10-25T11:44:58Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-be5abf/19885/summary.html
COMMIT: 610fecf
CMSSW: CMSSW_12_0_X_2021-10-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35812/19885/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 39
DQMHistoTests: Total histograms compared: 2998564
DQMHistoTests: Total failures: 62
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2998479
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 38 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 165 log files, 37 edm output root files, 39 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-10-25T12:00:43Z

+1

cmsbuild · 2021-10-25T12:01:09Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

DQM/SiStripMonitorClient/python/SiStripSourceConfigP5_cff.py

mmusich · 2021-10-26T07:50:37Z

Is there any further concern on this PR? Please let me know, thank you!

perrotta · 2021-10-26T08:01:42Z

Is there any further concern on this PR? Please let me know, thank you!

Not really: just waiting for the IB tests results in CMSSW_12_1_X_2021-10-25-2300, as a last check (as usual)

perrotta · 2021-10-26T11:53:22Z

+1

It backports both MonitorTrackResiduals: do not apply PV compatibility cut when running cosmics #35811 and SiStripSourceConfigP5_cff remove parameters added by mistake in #35811 #35826
Succesfully tested in the master IB CMSSW_12_1_X_2021-10-25-2300

cmsbuild added this to the CMSSW_12_0_X milestone Oct 24, 2021

cmsbuild added backport dqm-pending orp-pending pending-signatures tests-pending labels Oct 24, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 24, 2021

cmsbuild added the bug-fix label Oct 24, 2021

cmsbuild added the urgent label Oct 24, 2021

cmsbuild added tests-approved backport-ok and removed tests-started backport labels Oct 24, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Oct 25, 2021

cmsbuild added tests-started and removed tests-approved labels Oct 25, 2021

MonitorTrackResiduals: do not apply PV compatibility cut when running…

610fecf

… cosmics

mmusich force-pushed the removeVertexCutForCosmicsResiduals_12_0_X branch from 73a5a16 to 610fecf Compare October 25, 2021 08:33

cmsbuild added dqm-pending pending-signatures tests-pending and removed dqm-approved fully-signed tests-started labels Oct 25, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 25, 2021

cmsbuild added tests-approved and removed tests-started labels Oct 25, 2021

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Oct 25, 2021

perrotta reviewed Oct 26, 2021

View reviewed changes

DQM/SiStripMonitorClient/python/SiStripSourceConfigP5_cff.py Show resolved Hide resolved

cmsbuild added orp-approved and removed orp-pending labels Oct 26, 2021

cmsbuild merged commit 53af421 into cms-sw:CMSSW_12_0_X Oct 26, 2021

This was referenced Oct 26, 2021

Build CMSSW_12_0_3_patch1 #35852

Closed

Build CMSSW_12_0_3_patch1 #35853

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`MonitorTrackResiduals`: do not apply PV compatibility cut when running cosmics [12.0.X] #35812

`MonitorTrackResiduals`: do not apply PV compatibility cut when running cosmics [12.0.X] #35812

mmusich commented Oct 24, 2021

cmsbuild commented Oct 24, 2021 •

edited

mmusich commented Oct 24, 2021

mmusich commented Oct 24, 2021

tvami commented Oct 24, 2021

cmsbuild commented Oct 24, 2021

jfernan2 commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

mmusich commented Oct 25, 2021

mmusich commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

mmusich commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

jfernan2 commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

mmusich commented Oct 26, 2021

perrotta commented Oct 26, 2021

perrotta commented Oct 26, 2021

	return (!applyVertexCut_ \|\|
	(track.pt() > 0.75 && std::abs(track.dxy(vertices->at(0).position())) < 5 * track.dxyError()));
	},

MonitorTrackResiduals: do not apply PV compatibility cut when running cosmics [12.0.X] #35812

MonitorTrackResiduals: do not apply PV compatibility cut when running cosmics [12.0.X] #35812

Conversation

mmusich commented Oct 24, 2021

PR description:

No regression is expected for collision runs (pp or HI).

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Oct 24, 2021 • edited

mmusich commented Oct 24, 2021

mmusich commented Oct 24, 2021

tvami commented Oct 24, 2021

cmsbuild commented Oct 24, 2021

Comparison Summary

jfernan2 commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

mmusich commented Oct 25, 2021

mmusich commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

mmusich commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

Comparison Summary

jfernan2 commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

mmusich commented Oct 26, 2021

perrotta commented Oct 26, 2021

perrotta commented Oct 26, 2021

`MonitorTrackResiduals`: do not apply PV compatibility cut when running cosmics [12.0.X] #35812

`MonitorTrackResiduals`: do not apply PV compatibility cut when running cosmics [12.0.X] #35812

cmsbuild commented Oct 24, 2021 •

edited