Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to DQM issue 35813: crash in UnitTest of DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py #35814

Closed
wants to merge 1 commit into from
Closed

Fix to DQM issue 35813: crash in UnitTest of DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py #35814

wants to merge 1 commit into from

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Oct 25, 2021 •
edited

Declaring VertexCut type in DQM/SiStripMonitorTrack/python/SiStripMonitorTrack_cfi.py which is imported from DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py

Following #35811

Fixes #35813

@cmsbuild cmsbuild added this to the CMSSW_12_1_X milestone Oct 25, 2021
@jfernan2
Copy link
Contributor Author

jfernan2 commented Oct 25, 2021 •
edited

test parameters:

  • addpkg = DQM/Integration

@jfernan2
Copy link
Contributor Author

please test

@jfernan2 jfernan2 mentioned this pull request Oct 25, 2021
Closed
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35814/26175

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

  • DQM/SiStripMonitorTrack (dqm)

@emanueleusai, @ahmad3213, @jfernan2, @rvenditti, @pbo0, @pmandrik can you please review it and eventually sign? Thanks.
@arossi83, @hdelanno, @sroychow, @fioriNTU, @jandrea, @idebruyn, @threus this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

@jfernan2 could you please write in the title and in the PR description what is this PR doing and fixing, instead of just referring to a github issue nr?

@jfernan2 jfernan2 changed the title Fix to DQM issue 35813 Fix to DQM issue 35813: crash in UnitTest of DQM/Integration/python/clients/sistrip_dqm_sourceclient-live_cfg.py Oct 25, 2021
@jfernan2
Copy link
Contributor Author

Yes, sure. Done. Sorry.

mmusich
mmusich reviewed Oct 25, 2021
View reviewed changes
DQM/SiStripMonitorTrack/python/SiStripMonitorTrack_cfi.py
@@ -19,6 +19,7 @@
ModulesToBeExcluded = cms.vuint32(),

Mod_On = cms.bool(False),
VertexCut = cms.untracked.bool(True),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the right fix. I haven't touched this module.
I'll submit the right fix shortly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #35826

@jfernan2
Copy link
Contributor Author

please abort

@jfernan2 jfernan2 closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmusich mmusich mmusich left review comments

Assignees
No one assigned
Labels
code-checks-approved dqm-pending orp-pending pending-signatures tests-pending
Projects
None yet
Milestone
CMSSW_12_1_X
Development

Successfully merging this pull request may close these issues.

Unit failure in DQM/Integration
4 participants
@jfernan2 @cmsbuild @perrotta @mmusich