Data Format for hadronic showers in muon system #35836

kakwok · 2021-10-25T15:21:04Z

PR description:

PR validation:

This PR creates new data formats to contain hadronic showers in the Muon system. Specifically, CSC and DT rechits are clustered with Cambridge-Aachen(CA) algorithm by calling fast-jet directly. The new cluster objects keep the persistent reference pointers to the constituent rechit collection.

This is an essential ingredient for an HLT path for LLP in Run 3.
This PR supersedes #35543, and expand to

Detailed information are presented in these meetings:
Presentation at Muon POG meeting, Oct 25
Presentation at Reco meeting, Oct 15

cmsbuild · 2021-10-25T15:27:33Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26201

This PR adds an extra 32KB to repository
Found files with invalid states:
- DataFormats/MuonReco/src/MuonShowerRechitCluster.cc:
  - Added: de74f43
  - Deleted: 4c48598
- DataFormats/MuonReco/interface/MuonShowerRechitCluster.h:
  - Added: de74f43
  - Modified: 16d833a
  - Deleted: 4c48598

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26201/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26201/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26201/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26201/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

DataFormats/MuonReco/interface/MuonShowerCluster.h

RecoMuon/MuonShowerProducer/plugins/CSCRechitClusterProducer.cc

slava77

this is partial, considering the code-checks did not pass and that there is a class renaming in place.
Please also address comments already made by @VinInn

DataFormats/MuonReco/interface/MuonShowerCSCCluster.h

RecoMuon/MuonShowerProducer/plugins/CSCRechitClusterProducer.cc

RecoMuon/MuonShowerProducer/python/cscRechitCluster_cfi.py

cmsbuild · 2021-11-02T19:52:05Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26376

This PR adds an extra 28KB to repository
Found files with invalid states:
- RecoMuon/MuonShowerProducer/plugins/CSCRechitClusterProducer.cc:
  - Added: b483be7
  - Modified: ad3445c, 16d833a, 99a1611
  - Deleted: 6f12e72
- RecoMuon/MuonShowerProducer/plugins/BuildFile.xml:
  - Added: b483be7
  - Modified: 99a1611
  - Deleted: 6f12e72
- RecoMuon/MuonShowerProducer/BuildFile.xml:
  - Added: ad3445c
  - Modified: 99a1611
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerCSCCluster.h:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- RecoMuon/MuonShowerProducer/plugins/DTRechitClusterProducer.cc:
  - Added: 99a1611
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerDTCluster.h:
  - Added: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/src/MuonShowerRechitCluster.cc:
  - Added: de74f43
  - Deleted: 4c48598
- DataFormats/MuonReco/src/MuonShowerCluster.cc:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/src/MuonShowerCSCCluster.cc:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- RecoMuon/MuonShowerProducer/python/cscRechitCluster_cfi.py:
  - Added: b483be7
  - Modified: ad3445c
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerRechitCluster.h:
  - Added: de74f43
  - Modified: 16d833a
  - Deleted: 4c48598
- DataFormats/MuonReco/src/MuonShowerDTCluster.cc:
  - Added: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/interface/MuonShowerCluster.h:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26376/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26376/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26376/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26376/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-11-03T14:20:24Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26393

This PR adds an extra 60KB to repository
Found files with invalid states:
- RecoMuon/MuonShowerProducer/plugins/CSCRechitClusterProducer.cc:
  - Added: b483be7
  - Modified: ad3445c, 16d833a, 99a1611
  - Deleted: 6f12e72
- RecoMuon/MuonShowerProducer/plugins/BuildFile.xml:
  - Added: b483be7
  - Modified: 99a1611
  - Deleted: 6f12e72
- RecoMuon/MuonShowerProducer/BuildFile.xml:
  - Added: ad3445c
  - Modified: 99a1611
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerCSCCluster.h:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- RecoMuon/MuonShowerProducer/plugins/DTRechitClusterProducer.cc:
  - Added: 99a1611
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerDTCluster.h:
  - Added: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/src/MuonShowerRechitCluster.cc:
  - Added: de74f43
  - Deleted: 4c48598
- DataFormats/MuonReco/src/MuonShowerCluster.cc:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/src/MuonShowerCSCCluster.cc:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- RecoMuon/MuonShowerProducer/python/cscRechitCluster_cfi.py:
  - Added: b483be7
  - Modified: ad3445c
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerRechitCluster.h:
  - Added: de74f43
  - Modified: 16d833a
  - Deleted: 4c48598
- DataFormats/MuonReco/src/MuonShowerDTCluster.cc:
  - Added: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/interface/MuonShowerCluster.h:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-checks:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26393/code-checks.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26393/code-checks.patch | patch -p1
You can also run scram build code-checks to apply code checks directly
code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26393/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26393/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-11-03T23:01:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26405

This PR adds an extra 24KB to repository
Found files with invalid states:
- RecoMuon/MuonShowerProducer/plugins/CSCRechitClusterProducer.cc:
  - Added: b483be7
  - Modified: ad3445c, 16d833a, 99a1611
  - Deleted: 6f12e72
- RecoMuon/MuonShowerProducer/plugins/BuildFile.xml:
  - Added: b483be7
  - Modified: 99a1611
  - Deleted: 6f12e72
- RecoMuon/MuonShowerProducer/BuildFile.xml:
  - Added: ad3445c
  - Modified: 99a1611
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerCSCCluster.h:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- RecoMuon/MuonShowerProducer/plugins/DTRechitClusterProducer.cc:
  - Added: 99a1611
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerDTCluster.h:
  - Added: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/src/MuonShowerRechitCluster.cc:
  - Added: de74f43
  - Deleted: 4c48598
- DataFormats/MuonReco/src/MuonShowerCluster.cc:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/src/MuonShowerCSCCluster.cc:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8
- RecoMuon/MuonShowerProducer/python/cscRechitCluster_cfi.py:
  - Added: b483be7
  - Modified: ad3445c
  - Deleted: 6f12e72
- DataFormats/MuonReco/interface/MuonShowerRechitCluster.h:
  - Added: de74f43
  - Modified: 16d833a
  - Deleted: 4c48598
- DataFormats/MuonReco/src/MuonShowerDTCluster.cc:
  - Added: 99a1611
  - Deleted: 66eb6e8
- DataFormats/MuonReco/interface/MuonShowerCluster.h:
  - Added: 4c48598
  - Modified: 99a1611
  - Deleted: 66eb6e8

cmsbuild · 2021-11-27T18:17:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35836/26947

This PR adds an extra 16KB to repository

cmsbuild · 2021-11-27T18:17:28Z

Pull request #35836 was updated. @jpata, @missirol, @cmsbuild, @Martin-Grunewald, @slava77 can you please check and sign again.

missirol · 2021-11-29T08:26:37Z

please test

cmsbuild · 2021-11-29T11:33:58Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d581b0/20813/summary.html
COMMIT: 5b73c34
CMSSW: CMSSW_12_2_X_2021-11-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35836/20813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 3247873
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3247851
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

missirol · 2021-11-29T12:32:36Z

+hlt

slava77 · 2021-11-29T20:54:46Z

+reconstruction

for #35836 5b73c34

code changes are in line with the PR description and the follow up review
- the new code is not a part of a testable workflow, which is OK considering the integration needs/constraints for HLT
jenkins tests pass

cmsbuild · 2021-11-29T20:55:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2021-11-30T00:52:21Z

+1

cmsbuild added this to the CMSSW_12_1_X milestone Oct 25, 2021

cmsbuild added code-checks-pending new-package-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 25, 2021

kakwok mentioned this pull request Oct 25, 2021

Format for clustering CSC rechits with jet algorithms #35543

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 25, 2021

VinInn reviewed Oct 25, 2021

View reviewed changes

DataFormats/MuonReco/interface/MuonShowerCluster.h Outdated Show resolved Hide resolved

VinInn reviewed Oct 25, 2021

View reviewed changes

DataFormats/MuonReco/interface/MuonShowerCluster.h Outdated Show resolved Hide resolved

VinInn reviewed Oct 25, 2021

View reviewed changes

RecoMuon/MuonShowerProducer/plugins/CSCRechitClusterProducer.cc Outdated Show resolved Hide resolved

smuzaffar modified the milestones: CMSSW_12_1_X, CMSSW_12_2_X Oct 29, 2021

slava77 reviewed Oct 29, 2021

View reviewed changes

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 2, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Nov 2, 2021

cmsbuild added code-checks-rejected code-checks-pending and removed code-checks-pending code-checks-rejected labels Nov 3, 2021

kakwok force-pushed the MuonShowerCluster_from_12_1_0_pre4 branch from ddb7ae3 to 5b73c34 Compare November 27, 2021 18:09

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Nov 27, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 27, 2021

cmsbuild added tests-started and removed tests-pending labels Nov 29, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 29, 2021

cmsbuild added hlt-approved and removed hlt-pending labels Nov 29, 2021

cmsbuild added fully-signed reconstruction-approved and removed reconstruction-pending pending-signatures labels Nov 29, 2021

cmsbuild added orp-approved and removed orp-pending labels Nov 30, 2021

cmsbuild merged commit 737d291 into cms-sw:master Nov 30, 2021

cmsbuild mentioned this pull request Nov 30, 2021

(Un)packers for hadronic showers at the uGMT input and output #35627

Merged

kakwok mentioned this pull request Dec 1, 2021

Update HLT filter for MuonRechitClusters #36325

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Data Format for hadronic showers in muon system #35836

Data Format for hadronic showers in muon system #35836

kakwok commented Oct 25, 2021

cmsbuild commented Oct 25, 2021

slava77 left a comment

cmsbuild commented Nov 2, 2021

cmsbuild commented Nov 3, 2021

cmsbuild commented Nov 3, 2021

cmsbuild commented Nov 27, 2021

cmsbuild commented Nov 27, 2021

missirol commented Nov 29, 2021

cmsbuild commented Nov 29, 2021

missirol commented Nov 29, 2021

slava77 commented Nov 29, 2021

cmsbuild commented Nov 29, 2021

qliphy commented Nov 30, 2021

Data Format for hadronic showers in muon system #35836

Data Format for hadronic showers in muon system #35836

Conversation

kakwok commented Oct 25, 2021

PR description:

PR validation:

cmsbuild commented Oct 25, 2021

slava77 left a comment

Choose a reason for hiding this comment

cmsbuild commented Nov 2, 2021

cmsbuild commented Nov 3, 2021

cmsbuild commented Nov 3, 2021

cmsbuild commented Nov 27, 2021

cmsbuild commented Nov 27, 2021

missirol commented Nov 29, 2021

cmsbuild commented Nov 29, 2021

Comparison Summary

missirol commented Nov 29, 2021

slava77 commented Nov 29, 2021

cmsbuild commented Nov 29, 2021

qliphy commented Nov 30, 2021