OMTF o2o upgrade

[michalszleper]

PR description:

Created a new OMTF configuration object L1TMuonOverlapFwVersion to be used in o2o, a dedicated ES producer and a new o2o online producer. Also necessary was an appropriate modification in L1TMuonOverlapObjectKeysOnlineProd.cc and little additions and modifications in several other packages in order to include the new record. There is also some standalone test code of the new record in Utilities, which is of lesser importance.

PR validation:

The code has been tested with o2o.sh independently by myself and Hyejin Kwon, with input from the OMDS and output in a local sqlite file. Everything was checked to work such as expected from o2o. Writing and reading the new record in a standalone way was also tested using the code in Utilities.

if this PR is a backport please specify the original PR and why you need to backport that PR:

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35876/26274

• This PR adds an extra 80KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35876/26274/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35876/26274/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[tvami]

Hi @michalszleper please note that you have forgotten to do code-checks so the PR tests cant be triggered.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35876/26541

• This PR adds an extra 156KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35876/26541/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35876/26541/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[michalszleper]

I changed edm::EDAnalyzer to edm::one::EDAnalyzer, hope that's OK.

…

________________________________________ From: Tamas Vami ***@***.*** Sent: 12 November 2021 02:05 To: cms-sw/cmssw Cc: Michal Szleper; Mention Subject: Re: [cms-sw/cmssw] OMTF o2o upgrade (PR #35876) Hi @michalszleper<https://github.com/michalszleper> please fix this error https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e7108/20478/llvm-analysis/legacy-mod-sa.txt as well, thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#35876 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABVYFN4CU4KP47ML62COEHTULRR45ANCNFSM5G4ME7AQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35876/26597

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #35876 was updated. @malbouis, @yuanchao, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please check and sign again.

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5e7108/20501/summary.html
COMMIT: 05dd25a
CMSSW: CMSSW_12_2_X_2021-11-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35876/20501/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2902040
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2902018
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[tvami]

Ok it looks good to me, I dont have any further comments, @yuanchao anything from your side?

[yuanchao]

Regardless to set GT via autoCond, I see most problems are from the deprecated ES:get and edm::EDAnalyzer are actually from the included L1T XXXviewers and XXXwriters. They need to be fixed in separated PRs. For others, I don't have further comments. It's ok with me.

[tvami]

+alca

[ggovi]

+db

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1