Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customize OnlineBeamSpotESProducer inputs to be refreshed at each LS in online DQM [12.0.X] #35897

Merged

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Oct 29, 2021

backport of #35896

PR description:

During the 2021 October LHC beam test run it was noticed that, while in the first run with reasonable placing of the LHC luminous region (346373) an online beamspot measurement was available at around LS=10 (see online DQM GUI and log of the upload to the Conditions Database),

image

the information about the change of condition was not propagated properly to the other clients (see e.g. this plot from the same run of the track distance w.r.t BeamSpot: online DQM GUI).

image

This likely means that at P5 the refresh of the conditions needed for the OnlineBeamSposESProducer arbitration was not enabled (as I think the frontier connection is configured as for the HLT).
We provide hear the same customization of the GlobalTag ESSource used in the HLT menu to recover from this issue.
I notice en passant that the next run (346374) did pick up the right conditions in the online GUI ( link ) and the Express DQM instead picked up the right conditions in both cases, corroborating the case for a missing refresh of the input.

PR validation:

This PR should be tested in the DQM online playback system using run 346373.

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #35896
cc:
@gennai @francescobrivio @mtosi @vmariani

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 29, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor

@ahmad3213 @pmandrik @jfernan2 this should be tested with playback on run 346373 please.
And we would like to see the DQM output of that replay in order to check that the correction actually is propagated to all DQM clients correctly.
Thanks!

@francescobrivio
Copy link
Contributor

urgent

@francescobrivio
Copy link
Contributor

type bug-fix

@francescobrivio
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

Pull request #35897 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Oct 29, 2021

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a97f80/20045/summary.html
COMMIT: 338c01b
CMSSW: CMSSW_12_0_X_2021-10-28-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35897/20045/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1
Tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

francescobrivio commented Oct 29, 2021

@perrotta @qliphy this is all signed, would be good to merge it asap so DQM (@ahmad3213 and @pmandrik) can deploy in production in P5 for the SB tonight.

The validation comes from this plot:
Schermata 2021-10-29 alle 18 08 20

which shows 1 peak around zero rather than 2 peaks as it was seen online yesterday in:

Schermata 2021-10-29 alle 18 09 53

@qliphy
Copy link
Contributor

qliphy commented Oct 30, 2021

@francescobrivio Ok, we can merge it now. But notice usually we need the master PR to be merged first.

@qliphy
Copy link
Contributor

qliphy commented Oct 30, 2021

+1

@cmsbuild cmsbuild merged commit 57cd566 into cms-sw:CMSSW_12_0_X Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants