Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrict RunHI2011 to 182124:40, used in the short matrix wf 140.53 #35912

Merged
merged 1 commit into from Nov 6, 2021

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Oct 29, 2021

this is to improve stability in PR tests where DAS occasionally returns different files for wf 140.53

Due to a rather large number of files in 182124 /HIMinBiasUPC/HIRun2011-v1/RAW (301 file) the order of files in the das query changes occasionally, which leads to different events produced in PR tests for wf 140.53.

This PR is selecting LS 40 from the run, which should select just one file, the same file that was processed in the PR tests for this workflow in a recent IB CMSSW_12_1_X_2021-10-28-2300. The number of events in the selection is still fairly large (1428) for PR-like or even somewhat longer tests.

I'm not sure if the LS selection in relval_steps.py directly applies to relval submission, where more events may be needed. However, it's very likely that we will not run relvals for this data (I see that the last /HIMinBiasUPC/CMSSW_*/DQMIO was in 11_1_0)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35912/26309

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor Author

slava77 commented Oct 29, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6216aa/20072/summary.html
COMMIT: 8fa12cd
CMSSW: CMSSW_12_2_X_2021-10-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/35912/20072/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6216aa/20072/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6216aa/20072/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test TestDQMServicesDemo had ERRORS

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2959 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901440
  • DQMHistoTests: Total failures: 32682
  • DQMHistoTests: Total nulls: 7
  • DQMHistoTests: Total successes: 2868729
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor Author

slava77 commented Oct 29, 2021

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

this is expected here (only one file is selected now) and the comparisons show no differences in 140.53 (confirming that the same input is used here and in the baseline).
So, this PR tests worked as expected.

@slava77
Copy link
Contributor Author

slava77 commented Nov 4, 2021

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2
please check this PR.
Thank you.

@srimanob
Copy link
Contributor

srimanob commented Nov 4, 2021

Regarding your question in the PR description, relvals submission will use this setting also. @slava77

@srimanob
Copy link
Contributor

srimanob commented Nov 4, 2021

+1

This PR is to limit the LS used for HI 2011 workflow. It should be OK, to make PR test more stable. If we need relvals, PdmV should modify this before submission happens.

@slava77
Copy link
Contributor Author

slava77 commented Nov 6, 2021

@cms-sw/pdmv-l2
please check this PR.
Thank you.

@kskovpen
Copy link
Contributor

kskovpen commented Nov 6, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 6, 2021

+1

@perrotta
Copy link
Contributor

perrotta commented Nov 6, 2021

merge

  • unit test erro had been solved since a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants