Removed obsolete SIM classes and updated few obsolete interfaces #35926

civanch · 2021-10-31T23:05:59Z

PR description:

Several classes in CMSSW become obsolete after migration to Geant4 10.7 and will be a problem with newer Geant4 versions. No change in any WF is expected.

PR validation:

private

cmsbuild · 2021-10-31T23:11:19Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35926/26333

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimG4Core/PhysicsLists/src/CMSHadronPhysicsFTFP_BERT106.cc modified in PR(s): Run3-sim95 Small fix which works with future Geant4 versions #35924
- File SimG4Core/PhysicsLists/src/MonopoleTransportation.cc modified in PR(s): Run3-sim95 Small fix which works with future Geant4 versions #35924

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35926/26333/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35926/26333/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2021-10-31T23:25:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35926/26334

This PR adds an extra 24KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File SimG4Core/PhysicsLists/src/CMSHadronPhysicsFTFP_BERT106.cc modified in PR(s): Run3-sim95 Small fix which works with future Geant4 versions #35924
- File SimG4Core/PhysicsLists/src/MonopoleTransportation.cc modified in PR(s): Run3-sim95 Small fix which works with future Geant4 versions #35924

cmsbuild · 2021-10-31T23:25:52Z

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

Alignment/LaserAlignmentSimulation (alca)
SimG4Core/PhysicsLists (simulation)

@malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@adewit, @makortel, @cvuosalo, @rovere, @bsunanda, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

civanch · 2021-10-31T23:26:10Z

please test

cmsbuild · 2021-11-01T02:40:59Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1691ff/20127/summary.html
COMMIT: a5393fb
CMSSW: CMSSW_12_2_X_2021-10-31-0000/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35926/20127/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

135.4

----- Begin Fatal Exception 01-Nov-2021 02:51:00 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

136.8311

----- Begin Fatal Exception 01-Nov-2021 02:51:40 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 01-Nov-2021 02:51:40 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1/step2_MinimumBias2010A+MinimumBias2010A+RECOSKIMALCA+HARVESTDR1.log
136.72411136.72411_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMINIAOD_data2016UL_HIPM+HARVESTDR2_REMINIAOD_data2016UL_HIPM.log
136.72412136.72412_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM/step2_RunJetHT2016B_reminiaodUL+RunJetHT2016B_reminiaodUL+REMININANO_data2016UL_HIPM+HARVESTDR2_REMININANO_data2016UL_HIPM.log

Expand to see more relval errors ...

AddOn Tests

fastsim1

----- Begin Fatal Exception 01-Nov-2021 02:53:17 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 01-Nov-2021 02:53:19 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

hlt_mc_Fake1

----- Begin Fatal Exception 01-Nov-2021 02:57:34 CET-----------------------
An exception of category 'EventSetupConflict' occurred while
   [0] Calling beginJob
Exception Message:
two EventSetup Sources want to deliver type="PPSAssociationCuts" label=""
 from record PPSAssociationCutsRcd. The two providers are 
1) type="PPSAssociationCutsESSource" label="ppsAssociationCutsESSource"
2) type="PoolDBESSource" label="GlobalTag"
Please either
   remove one of these Sources
   or find a way of configuring one of them so it does not deliver this data
   or use an es_prefer statement in the configuration to choose one.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

tvami · 2021-11-01T06:20:35Z

@cmsbuild , please test with #35766

code-format

cmsbuild · 2021-11-01T14:25:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35926/26345

This PR adds an extra 12KB to repository

cmsbuild · 2021-11-01T14:25:55Z

Pull request #35926 was updated. @malbouis, @civanch, @yuanchao, @mdhildreth, @cmsbuild, @francescobrivio, @tvami can you please check and sign again.

civanch · 2021-11-01T15:49:47Z

@cmsbuild , please test with #35766

cmsbuild · 2021-11-01T18:54:14Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1691ff/20160/summary.html
COMMIT: c3233ed
CMSSW: CMSSW_12_2_X_2021-11-01-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35926/20160/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 42
DQMHistoTests: Total histograms compared: 2901890
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2901868
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
Checked 177 log files, 37 edm output root files, 42 DQM output files
TriggerResults: no differences found

civanch · 2021-11-02T00:37:45Z

+1

yuanchao · 2021-11-02T14:01:57Z

+1

cmsbuild · 2021-11-02T14:02:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

SimG4Core/PhysicsLists/src/CMSMonopolePhysics.cc

perrotta · 2021-11-02T14:17:01Z

+1

civanch added 2 commits October 31, 2021 23:56

updated monopole physics

2e7e775

removed obsolete classes

78caa6e

cmsbuild added this to the CMSSW_12_2_X milestone Oct 31, 2021

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures simulation-pending tests-pending labels Oct 31, 2021

civanch mentioned this pull request Oct 31, 2021

Run3-sim95 Small fix which works with future Geant4 versions #35924

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels Oct 31, 2021

code-check

a5393fb

cmsbuild added code-checks-pending and removed code-checks-rejected labels Oct 31, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 31, 2021

cmsbuild added tests-started and removed tests-pending labels Oct 31, 2021

cmsbuild added tests-rejected and removed tests-started labels Nov 1, 2021

cmsbuild added requires-external tests-started and removed tests-rejected labels Nov 1, 2021

cmsbuild added the code-checks-rejected label Nov 1, 2021

Update LaserOpticalPhysicsList.cc

c3233ed

code-format

cmsbuild added code-checks-pending and removed code-checks-rejected labels Nov 1, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 1, 2021

cmsbuild added requires-external tests-started and removed tests-pending labels Nov 1, 2021

cmsbuild added tests-approved and removed tests-started labels Nov 1, 2021

cmsbuild added simulation-approved and removed simulation-pending labels Nov 2, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Nov 2, 2021

tvami reviewed Nov 2, 2021

View reviewed changes

SimG4Core/PhysicsLists/src/CMSMonopolePhysics.cc Show resolved Hide resolved

tvami reviewed Nov 2, 2021

View reviewed changes

SimG4Core/PhysicsLists/src/CMSMonopolePhysics.cc Show resolved Hide resolved

cmsbuild added orp-approved and removed orp-pending labels Nov 2, 2021

cmsbuild merged commit 297d419 into cms-sw:master Nov 2, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed obsolete SIM classes and updated few obsolete interfaces #35926

Removed obsolete SIM classes and updated few obsolete interfaces #35926

civanch commented Oct 31, 2021 •

edited

cmsbuild commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

civanch commented Oct 31, 2021

cmsbuild commented Nov 1, 2021

tvami commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

civanch commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

civanch commented Nov 2, 2021

yuanchao commented Nov 2, 2021

cmsbuild commented Nov 2, 2021

perrotta commented Nov 2, 2021

Removed obsolete SIM classes and updated few obsolete interfaces #35926

Removed obsolete SIM classes and updated few obsolete interfaces #35926

Conversation

civanch commented Oct 31, 2021 • edited

PR description:

PR validation:

cmsbuild commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

cmsbuild commented Oct 31, 2021

civanch commented Oct 31, 2021

cmsbuild commented Nov 1, 2021

RelVals

RelVals-INPUT

AddOn Tests

tvami commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

civanch commented Nov 1, 2021

cmsbuild commented Nov 1, 2021

Comparison Summary

civanch commented Nov 2, 2021

yuanchao commented Nov 2, 2021

cmsbuild commented Nov 2, 2021

perrotta commented Nov 2, 2021

civanch commented Oct 31, 2021 •

edited