New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates on summary plot of GEM onlineDQM, a backport to 12_0_X #35954
Updates on summary plot of GEM onlineDQM, a backport to 12_0_X #35954
Conversation
A new Pull Request was created by @quark2 for CMSSW_12_0_X. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
@@ -50,17 +50,17 @@ void GEMRecHitSource::bookHistograms(DQMStore::IBooker& ibooker, edm::Run const& | |||
mapTotalRecHitPerEvtLayer_ = MEMap3Inf(this, | |||
"rechits_per_layer", | |||
"Total number of RecHits per event for each layers", | |||
50, | |||
2000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need 2000 bins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. We are currently seeing a lot of hits in some events and this would help us understand the situation.
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-271e3e/20185/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The criteria of the summary plot of GEM onlineDQM have been changed: From now on it goes red(error)/yellow(warning) which is determined by the ratio of error/warning status on each chamber.
Also binning of some plots have been changed to watch some recHit distribution more carefully.
PR validation:
Test are done and one can check again by
runTheMatrix
workflowsif this PR is a backport please specify the original PR and why you need to backport that PR:
This is a backport of #35952 to CMSSW_12_0_X to be deployed on the current runs
@jshlee @watson-ij