Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates on summary plot of GEM onlineDQM, a backport to 12_0_X #35954

Merged
merged 1 commit into from Nov 5, 2021

Conversation

quark2
Copy link
Contributor

@quark2 quark2 commented Nov 2, 2021

PR description:

The criteria of the summary plot of GEM onlineDQM have been changed: From now on it goes red(error)/yellow(warning) which is determined by the ratio of error/warning status on each chamber.

Also binning of some plots have been changed to watch some recHit distribution more carefully.

PR validation:

Test are done and one can check again by runTheMatrix workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #35952 to CMSSW_12_0_X to be deployed on the current runs

@jshlee @watson-ij

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

A new Pull Request was created by @quark2 for CMSSW_12_0_X.

It involves the following packages:

  • DQM/GEM (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@watson-ij this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jshlee
Copy link
Contributor

jshlee commented Nov 2, 2021

please test

@@ -50,17 +50,17 @@ void GEMRecHitSource::bookHistograms(DQMStore::IBooker& ibooker, edm::Run const&
mapTotalRecHitPerEvtLayer_ = MEMap3Inf(this,
"rechits_per_layer",
"Total number of RecHits per event for each layers",
50,
2000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need 2000 bins?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We are currently seeing a lot of hits in some events and this would help us understand the situation.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-271e3e/20185/summary.html
COMMIT: d4e324c
CMSSW: CMSSW_12_0_X_2021-11-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35954/20185/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2998542
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 38 files compared)
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

jfernan2 commented Nov 2, 2021

+1
Tested in Online DQM at P5

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 5, 2021

+1

@cmsbuild cmsbuild merged commit a846623 into cms-sw:CMSSW_12_0_X Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants