Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esConsumes in TTStubAssociator #35977

Merged
merged 1 commit into from Nov 9, 2021

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Nov 3, 2021

PR description:

Part of #31061.

PR validation:

Code compiles.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35977/26404

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2021

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • SimTracker/TrackTriggerAssociation (l1, simulation)

@cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please review it and eventually sign? Thanks.
@mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Nov 3, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-641152/20238/summary.html
COMMIT: d00ada1
CMSSW: CMSSW_12_2_X_2021-11-03-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35977/20238/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 04-Nov-2021 03:36:39 CET-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module TTStubAssociator_Phase2TrackerDigi_/'TTStubAssociatorFromPixelDigis'
Exception Message:
No data of type "TrackerGeometry" with label "" in record "TrackerTopologyRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 04-Nov-2021 03:37:47 CET-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module TTStubAssociator_Phase2TrackerDigi_/'TTStubAssociatorFromPixelDigis'
Exception Message:
No data of type "TrackerGeometry" with label "" in record "TrackerTopologyRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 04-Nov-2021 03:39:29 CET-----------------------
An exception of category 'NoProxyException' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'L1TrackTrigger_step'
   [2] Calling method for module TTStubAssociator_Phase2TrackerDigi_/'TTStubAssociatorFromPixelDigis'
Exception Message:
No data of type "TrackerGeometry" with label "" in record "TrackerTopologyRcd"
 Please add an ESSource or ESProducer to your job which can deliver this data.
----- End Fatal Exception -------------------------------------------------
Expand to see more relval errors ...

RelVals-INPUT

  • 23234.2123234.21_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD+Nano/step2_TTbar_14TeV+2026D49_ProdLike+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+MiniAOD+Nano.log
  • 23234.023234.0_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
  • 23234.10323234.103_TTbar_14TeV+2026D49Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal/step2_TTbar_14TeV+2026D49Aging3000+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14INPUT+DigiTrigger+RecoGlobal+HARVESTGlobal.log
Expand to see more relval errors ...

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35977/26410

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

Pull request #35977 was updated. @cmsbuild, @rekovic, @civanch, @cecilecaillol, @mdhildreth can you please check and sign again.

@makortel
Copy link
Contributor Author

makortel commented Nov 4, 2021

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-641152/20245/summary.html
COMMIT: 42160a6
CMSSW: CMSSW_12_2_X_2021-11-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35977/20245/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901862
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Nov 5, 2021

+1

@makortel
Copy link
Contributor Author

makortel commented Nov 8, 2021

ping @cms-sw/l1-l2

@rekovic
Copy link
Contributor

rekovic commented Nov 9, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 9, 2021

+1

@cmsbuild cmsbuild merged commit 76b324d into cms-sw:master Nov 9, 2021
@makortel makortel deleted the esconsumesTTStubAssociator branch November 9, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants