Removing obsolete code from CaloLayer1Setup - 12_1_X

[perrotta]

Backport of #35940

Originally coded by @BenjaminRS

"This PR removes obsolete code from the CaloLayer1 area which has been causing spurious elog warnings as described in Issue#34309. As suggested in this comment to PR#35873 I have removed the if else statement which was now obsolete"

PR validation:

Identical fix as already merged in master
It builds

[cmsbuild]

A new Pull Request was created by @perrotta (Andrea Perrotta) for CMSSW_12_1_X.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Removing obsolete code from CaloLayer1Setup #35940

[perrotta]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-02945c/20240/summary.html
COMMIT: 73a27db
CMSSW: CMSSW_12_1_X_2021-11-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35980/20240/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901440
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901418
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[perrotta]

@cms-sw/l1-l2 we plan to include this PR in the CMSSW_12_0_1 release that will be tentatively built by tomorrow.
It is identical to the same PR already merged in master as #35940, and therefore I believe there will be no objection from you to sign and include it also in 12_1_X.
Could you please have a look and sign it, if you agree?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1