Fix timing PCLs by adding EDMToMeConverter

[ChrisMisan]

PR description:
This PR follows #35874 and addresses the issue for the timing PCLs (TDC and Sampic).

PR validation:

• PCL of TDC was validated against relval 1041
• PCL of Sampic was validated using the manual test included in CalibPPS/TimingCalibration/test/

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-35988/26417

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @ChrisMisan (Christopher) for master.

It involves the following packages:

• CalibPPS/TimingCalibration (alca)
• Configuration/StandardSequences (operations)

@perrotta, @malbouis, @yuanchao, @tvami, @cmsbuild, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @fabferro, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @Martin-Grunewald, @missirol, @rovere, @lecriste, @mtosi, @ebrondol, @mmusich, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[tvami]

test parameters:

• workflows = 1041

[tvami]

@cmsbuild , please test

[tvami]

cc @tlampen @tocheng

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d770cc/20256/summary.html
COMMIT: 4204bc8
CMSSW: CMSSW_12_2_X_2021-11-03-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/35988/20256/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d770cc/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901862
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[tvami]

Hi @ChrisMisan I still dont see the new plots in here
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d770cc/20256/runTheMatrix-results/1041.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCAL+ALCASPLITPPSCAL+ALCAHARVDPPSCAL/DQM_V0001_R000305064__Express__PCLTest__ALCAPROMPT.root

is it not supposed to be in this file?

[tvami]

In general the dqmDir of AlCaReco/PPSDiamondSampicTimingCalibrationPCL is missing in that ROOT file

[ChrisMisan]

@tvami 1041 workflow is for the HPTDC, not Sampic, Sampic PCL for the moment can only be tested manually. For the HPTDC I don't expect any change to the plots, this fix is apparently needed for the harvester to correctly load files produced by the workers #35874

[tvami]

I understand that the SAMPIC cannot be tested. I dont understand why you say that for the HPTDC you dont expect changes. But let me rephrase #35988 (comment) --> the DQM plots dont exist, I dont understand why (for the HPTDC)

[tvami]

In general the dqmDir of AlCaReco/PPSDiamondSampicTimingCalibrationPCL is missing in that ROOT file

So correcting this msg
based on
https://github.com/cms-sw/cmssw/blob/master/CalibPPS/TimingCalibration/plugins/PPSTimingCalibrationPCLHarvester.cc#L152

I'd expect to have a dqm folder named AlCaReco/PPSTimingCalibrationPCL

[ChrisMisan]

Alright, maybe it'd be good to ask @forthommel but from what I understand TDC harvester isn't saving any plots so those intermediate files between worker->harvester are beeing dropped as temporary files:
https://github.com/forthommel/cmssw/blob/282611ea01492ca2b6966726f8748cff519ae64b/CalibPPS/TimingCalibration/p

[tvami]

@forthommel any comments?

[tvami]

+alca

• private communication confirmed Fix timing PCLs by adding EDMToMeConverter #35988 (comment)
• future development is to add plots to TDC
• SAMPIC will (and can only be) test with data

[tvami]

@perrotta @qliphy this is essentially fully signed

[qliphy]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.