New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10_6_X] Add producers/configs to refit muon tracks with standard TrackRefitter #36001
Conversation
Code checks and code format
A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_6_X. It involves the following packages:
@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
code-checks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36001/26434
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f63b6/20265/summary.html Comparison SummarySummary:
|
backport of #35620 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
considering that all other files are copied verbatim from the master version, I think that RecoTracker/TrackProducer/plugins/TrackExtraRekeyer.cc
should be as well
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f63b6/20311/summary.html Comparison SummarySummary:
|
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Almost a complete backport of #35620
except that for example
consumes(edm::InputTag)
has no matching function in 10_6_XThis refitting feature is nice to have in 10_6_X as some UltraLegacy analysis could make use of it.
PR validation:
The newly introduced unit tests work nicely.
if this PR is a backport please specify the original PR and why you need to backport that PR:
This is a backport of #35620
All credits to @bendavid @mmusich