Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10_6_X] Add producers/configs to refit muon tracks with standard TrackRefitter #36001

Merged
merged 2 commits into from Nov 10, 2021

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Nov 5, 2021

PR description:

Almost a complete backport of #35620
except that for example consumes(edm::InputTag) has no matching function in 10_6_X

This refitting feature is nice to have in 10_6_X as some UltraLegacy analysis could make use of it.

PR validation:

The newly introduced unit tests work nicely.

if this PR is a backport please specify the original PR and why you need to backport that PR:

This is a backport of #35620

All credits to @bendavid @mmusich

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2021

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_10_6_X.

It involves the following packages:

  • RecoTracker/TrackProducer (reconstruction)

@jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Nov 5, 2021

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Nov 5, 2021

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36001/26434

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f63b6/20265/summary.html
COMMIT: e642b39
CMSSW: CMSSW_10_6_X_2021-10-31-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36001/20265/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Nov 5, 2021

backport of #35620

Copy link
Contributor

@slava77 slava77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering that all other files are copied verbatim from the master version, I think that RecoTracker/TrackProducer/plugins/TrackExtraRekeyer.cc
should be as well

RecoTracker/TrackProducer/plugins/TrackExtraRekeyer.cc Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2021

Pull request #36001 was updated. @jpata, @cmsbuild, @slava77 can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Nov 7, 2021

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5f63b6/20311/summary.html
COMMIT: ccd9490
CMSSW: CMSSW_10_6_X_2021-11-07-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36001/20311/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215350
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 143 log files, 29 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@slava77
Copy link
Contributor

slava77 commented Nov 9, 2021

+reconstruction

for #36001 ccd9490

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 10, 2021

+1

@cmsbuild cmsbuild merged commit 3dd3f73 into cms-sw:CMSSW_10_6_X Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants