Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiclLayerTile compile time optimizations #36020

Merged
merged 3 commits into from Nov 6, 2021

Conversation

rovere
Copy link
Contributor

@rovere rovere commented Nov 6, 2021

PR description:

Purely technical, no regression expected.

PR validation:

Limited Matrix passed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36020/26469

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2021

A new Pull Request was created by @rovere (Marco Rovere) for master.

It involves the following packages:

  • DataFormats/HGCalReco (upgrade, reconstruction)
  • RecoHGCal/TICL (upgrade, reconstruction)

@jpata, @AdrianoDee, @srimanob, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @ebrondol, @clelange this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@rovere
Copy link
Contributor Author

rovere commented Nov 6, 2021

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-eef261/20298/summary.html
COMMIT: eed2da4
CMSSW: CMSSW_12_2_X_2021-11-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36020/20298/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2901862
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Nov 6, 2021

+Upgrade

Technical PR with no changes are expected. PR test runs fine.

@slava77
Copy link
Contributor

slava77 commented Nov 6, 2021

+reconstruction

for #36020 eed2da4

  • code changes are in line with the PR description/title
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 6, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants