Faster CSCALCTDigi::clear()

[Dr15Jones]

PR description:

All the digis now share an immutable empty hits container until the individual digis have their hits set.

This was a stand out timing for the IB RelVal's igprof report for workflow 136.731 for step2.

PR validation:

Code compiles.

[Dr15Jones]

From the report

 Rank | % total | Counts | Paths | Symbol name

      | 0.23 | 0.10 | 0.12 | 1 | 1 | CSCAnodeLCTProcessor::clear()
      | 0.34 | 0.15 | 0.18 | 3 | 3 | CSCALCTDigi::CSCALCTDigi()
      | 1.35 | 0.61 | 0.79 | 2 | 2 | CSCCorrelatedLCTDigi::clear()
[288] | 1.92 | 0.72 | 0.15 | 6 | 6 | CSCALCTDigi::clear()
      | 0.21 | 0.10 | 0.10 | 3 | 5 | std::vector<unsigned short, std::allocator<unsigned short> >::_M_default_append(unsigned long)
      | 0.12 | 0.06 | 0.12 | 2 | 4 | std::vector<std::vector<unsigned short, std::allocator<unsigned short> >, std::allocator<std::vector<unsigned short, std::allocator<unsigned short> > > >::_M_default_append(unsigned long)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36038/26494

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• DataFormats/CSCDigi (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@dildick, @ptcox, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0261ed/20340/summary.html
COMMIT: e328f2e
CMSSW: CMSSW_12_2_X_2021-11-08-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36038/20340/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 11634.911

----- Begin Fatal Exception 08-Nov-2021 18:07:59 CET-----------------------
An exception of category 'PluginNotFound' occurred while
   [0] Constructing the EventProcessor
Exception Message:
Unable to find plugin 'EcalBarrelGeometryEPdd4hep' in category 'CMS EDM Framework ParameterSet Description'. Please check spelling of name.
----- End Fatal Exception -------------------------------------------------

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0261ed/20410/summary.html
COMMIT: e328f2e
CMSSW: CMSSW_12_2_X_2021-11-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36038/20410/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2901862
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1