Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fix to integrationTests #36059

Merged
merged 1 commit into from Nov 9, 2021

Conversation

Sam-Harper
Copy link
Contributor

@Sam-Harper Sam-Harper commented Nov 9, 2021

Co-authored-by: Marino Missiroli

PR description:

This is a small fix to the hltIntegrationTests as spotted by Marino in #36051

#35987 had already merged so this is just a PR on top of that

Co-authored-by: Marino Missiroli <m.missiroli@cern.ch>
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36059/26521

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

A new Pull Request was created by @Sam-Harper (Sam Harper) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Nov 9, 2021

please test

thanks, Sam!

@missirol
Copy link
Contributor

missirol commented Nov 9, 2021

please abort

another PR is needed to fix unrelated issues with some of the PR tests..

@missirol
Copy link
Contributor

missirol commented Nov 9, 2021

please test with #36021

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2f57e4/20401/summary.html
COMMIT: 03df274
CMSSW: CMSSW_12_2_X_2021-11-09-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36059/20401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901868
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Nov 9, 2021

type bugfix

@missirol
Copy link
Contributor

missirol commented Nov 9, 2021

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Nov 9, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants