Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed trivial static in LinuxCPUTime to be const #3606

Merged
merged 1 commit into from May 1, 2014

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

Changed trivial static in LinuxCPUTime to be const

It involves the following packages:

Utilities/Timing

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-30-1400/src/Utilities/StaticAnalyzers/src/ClassDumper.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-30-1400/src/Utilities/StaticAnalyzers/src/CmsException.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-30-1400/src/Utilities/StaticAnalyzers/src/CmsSupport.cpp 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-30-1400/src/Utilities/StaticAnalyzers/src/ConstCastAwayChecker.cpp 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-30-1400/src/Utilities/StaticAnalyzers/src/ClassChecker.cpp: In member function 'void clangcms::WalkAST::ReportDeclRef(const clang::DeclRefExpr*)':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-30-1400/src/Utilities/StaticAnalyzers/src/ClassChecker.cpp:346:25: error: 'CMSThreadGuardAttr' was not declared in this scope
         if ( D->hasAttr() || D->hasAttr()) return;
                         ^
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-04-30-1400/src/Utilities/StaticAnalyzers/src/ClassChecker.cpp:346:45: error: no matching function for call to 'clang::VarDecl::hasAttr() const'
         if ( D->hasAttr() || D->hasAttr()) return;
                                             ^


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3606/1194/summary.html

@Dr15Jones
Copy link
Contributor Author

The test failure is unrelated to this change.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Apr 30, 2014

I forgot I need to pick up Patrick changes in an IB...

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 1, 2014
Multithreading -- Changed trivial static in LinuxCPUTime to be const
@ktf ktf merged commit 9bf6bad into cms-sw:CMSSW_7_1_X May 1, 2014
@Dr15Jones Dr15Jones deleted the makeStaticConstInLinuxCPUTime branch May 6, 2014 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants