Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for option "dbproxy" in hltListPaths #36069

Merged
merged 2 commits into from Nov 10, 2021

Conversation

missirol
Copy link
Contributor

PR description:

This PR provides a fix for cmd-line argument --dbproxy introduced in #35987 (see discussion post-merge in the latter PR).
The fix is needed to run correctly the HLT integration tests, and it will need to be backported to 12_1_X and 12_0_X (as #35987 was).

FYI: @Sam-Harper

PR validation:

Reproduced the error, and verified that this fix works as intended.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36069/26538

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

type bugfix

@missirol
Copy link
Contributor Author

For consistency, I applied the same change to hltGetConfiguration.

Unlike hltListPaths, the script hltGetConfiguration was not crashing earlier, b/c it uses
parser.parse_args(namespace = options.HLTProcessOptions()), while hltListPaths uses just parser.parse_args().

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36069/26540

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36069 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5bd45f/20427/summary.html
COMMIT: f049cf2
CMSSW: CMSSW_12_2_X_2021-11-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36069/20427/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2901890
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2901868
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

  • this PR should fix the IB errors discussed in this comment
  • this fix does not need dedicated backports, b/c it is being integrated in the backports of #35987 (see #36051 and #36052)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 10, 2021

+1

@cmsbuild cmsbuild merged commit 4f45315 into cms-sw:master Nov 10, 2021
@missirol missirol deleted the fix_hltListPaths branch March 27, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants