Migrate BeamSpot codes to new PoolDBOutputService methods

[francescobrivio]

PR description:

Part of cms-AlCaDB/AlCaTools#28
Updates to BeamSpot-related codes to:

• Create objects on stack (as suggested in this slide by @ggovi)
• Use writeOneIOV instead of writeOne
• Use appendOneIOV instead of appendSinceTime

PR validation:

Code compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

FYI: @dzuolo @mmusich

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36077/26550

• This PR adds an extra 44KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/BeamMonitor/plugins/BeamMonitor.cc modified in PR(s): Modernize plugins in DQM/BeamMonitor #35501
  • File DQM/BeamMonitor/plugins/FakeBeamMonitor.cc modified in PR(s): Modernize plugins in DQM/BeamMonitor #35501

[cmsbuild]

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

• Calibration/TkAlCaRecoProducers (alca)
• DQM/BeamMonitor (dqm)
• RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @slava77, @jpata, @francescobrivio, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @tocheng, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test with #36021

[tvami]

@cmsbuild please test with #36021

(FYI this is not needed anymore)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8dd381/20438/summary.html
COMMIT: 2a747a7
CMSSW: CMSSW_12_2_X_2021-11-09-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36077/20438/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 2901890
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2901862
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 41 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• code change according to PR description
• Jenkins tests pass

[jfernan2]

+1

[slava77]

+reconstruction

for #36077 2a747a7

• code changes are technical, in line with the PR description/title
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1