Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup of SIM core #3609

Merged
merged 1 commit into from May 1, 2014
Merged

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Apr 30, 2014

Clean-up of SIM core : improved info messages, removed unused variables/methods.

SteppingAction and StackingAction classes were optimized which bring few % speed-up.

The default g4SimHits configuration disable Castor and CastorShowerLibrary. Custom fragments for background study enable full simulation inside HF and Castor, disable RR, extends eta cuts, and the time cut.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_1_X.

cleanup of SIM core

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@civanch
Copy link
Contributor Author

civanch commented Apr 30, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

ktf added a commit that referenced this pull request May 1, 2014
@ktf ktf merged commit e0aa78a into cms-sw:CMSSW_7_1_X May 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants