New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate some ALCA code to new PoolDBOutputService
methods
#36090
Migrate some ALCA code to new PoolDBOutputService
methods
#36090
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36090/26574
|
A new Pull Request was created by @francescobrivio for master. It involves the following packages:
@malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild , please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I preface this by saying that I don't know the details of the latest AlCaDB sw-policy changes.
Still, some things were unclear to me, as I tried to show in the comments. Thanks in advance for your clarifications.
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b72500/20467/summary.html CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b72500/20467/llvm-analysis/legacy-mod-sa.txt for details. Comparison SummarySummary:
|
@cmsbuild please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36090/26602
|
Pull request #36090 was updated. @malbouis, @yuanchao, @Martin-Grunewald, @missirol, @ggovi, @francescobrivio, @tvami can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b72500/20503/summary.html CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b72500/20503/llvm-analysis/legacy-mod-sa.txt for details. Comparison SummarySummary:
|
+hlt |
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Part of cms-AlCaDB/AlCaTools#28
Migrated to use the new PoolDBOutput methods in
CondFormats/PhysicsToolsObjects/test/T*Writer.cc
andrestructured the AlCaRecoTriggerBits writer (thanks @ggovi for the help!)
PR validation:
Code compiles and
scramv1 b runtests
runs fineBackport:
N/A
FYI @cms-sw/alca-l2 @hjkwon260