Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some ALCA code to new PoolDBOutputService methods #36090

Merged
merged 2 commits into from Nov 13, 2021

Conversation

francescobrivio
Copy link
Contributor

PR description:

Part of cms-AlCaDB/AlCaTools#28
Migrated to use the new PoolDBOutput methods in CondFormats/PhysicsToolsObjects/test/T*Writer.cc and
restructured the AlCaRecoTriggerBits writer (thanks @ggovi for the help!)

PR validation:

Code compiles and scramv1 b runtests runs fine

Backport:

N/A

FYI @cms-sw/alca-l2 @hjkwon260

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36090/26574

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • CondFormats/PhysicsToolsObjects (db, alca)
  • CondTools/HLT (hlt, db)

@malbouis, @yuanchao, @cmsbuild, @missirol, @Martin-Grunewald, @ggovi, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@silviodonato, @mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Nov 11, 2021

@cmsbuild , please test

Copy link
Contributor

@missirol missirol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I preface this by saying that I don't know the details of the latest AlCaDB sw-policy changes.
Still, some things were unclear to me, as I tried to show in the comments. Thanks in advance for your clarifications.

CondTools/HLT/src/AlCaRecoTriggerBitsRcdUpdate.cc Outdated Show resolved Hide resolved
CondTools/HLT/src/AlCaRecoTriggerBitsRcdUpdate.cc Outdated Show resolved Hide resolved
CondTools/HLT/src/AlCaRecoTriggerBitsRcdUpdate.cc Outdated Show resolved Hide resolved
CondTools/HLT/src/AlCaRecoTriggerBitsRcdUpdate.cc Outdated Show resolved Hide resolved
CondTools/HLT/src/AlCaRecoTriggerBitsRcdUpdate.cc Outdated Show resolved Hide resolved
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b72500/20467/summary.html
COMMIT: 44b7a7b
CMSSW: CMSSW_12_2_X_2021-11-11-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36090/20467/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b72500/20467/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2902040
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902018
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36090/26602

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

Pull request #36090 was updated. @malbouis, @yuanchao, @Martin-Grunewald, @missirol, @ggovi, @francescobrivio, @tvami can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b72500/20503/summary.html
COMMIT: a166f76
CMSSW: CMSSW_12_2_X_2021-11-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36090/20503/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b72500/20503/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2902040
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902018
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@tvami
Copy link
Contributor

tvami commented Nov 12, 2021

+1

  • tests run fine
  • PR in line with the describtion

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Nov 13, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants