Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize several modules in TopQuarkAnalysis #36098

Merged
merged 6 commits into from Nov 13, 2021

Conversation

makortel
Copy link
Contributor

PR description:

Part of #31061.

Also change PhysicsTools::Calibration::MVAComputer::getProcessors() const to return const pointers to contained VarProcessor processor objects as required by ESProduct policies.

PR validation:

Unit tests of TopQuarkAnalysis/TopEventSelection, TopQuarkAnalysis/TopEventProducers, and TopQuarkAnalysis/TopJetCombination succeed when run with #35588.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36098/26591

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

  • CondFormats/PhysicsToolsObjects (db, alca)
  • PhysicsTools/MVAComputer (analysis)
  • TopQuarkAnalysis/TopEventSelection (analysis)
  • TopQuarkAnalysis/TopJetCombination (analysis)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @tvami, @santocch, @francescobrivio can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @tocheng, @JyothsnaKomaragiri, @mmusich, @demuller, @andrzejnovak, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c279e0/20484/summary.html
COMMIT: 0c0a9c7
CMSSW: CMSSW_12_2_X_2021-11-11-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36098/20484/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 2902040
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2902006
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@yuanchao
Copy link
Contributor

+1

  • esconsumes migration, new edanalyzer migration for MVAcomputer
  • unit tests passed

@tvami
Copy link
Contributor

tvami commented Nov 12, 2021

+db

  • Jenkins tests pass
  • PR in line with the description

@qliphy
Copy link
Contributor

qliphy commented Nov 13, 2021

merge

@santocch
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants