fixed CorrWithOverlapRemovalCondition.cc

[namppl]

PR description:

Recently the overlap-removal condition (for 2 correlated legs + 1 overlap-removal leg) was found to be misconfigured in both L1 firmware and emulator code. The code has been fixed in accordance with the updated L1 firmware.

PR validation:

Unit tests done

[cmsbuild]

@namppl, CMSSW_12_2_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36103/26599

• This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36103/26599/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36103/26599/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36103/26600

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @namppl (Kyungwook Nam) for master.

It involves the following packages:

• L1Trigger/L1TGlobal (l1)

@cmsbuild, @rekovic, @cecilecaillol can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[rekovic]

this is under discussion.

[rekovic]

hold

[cmsbuild]

Pull request has been put on hold by @rekovic
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[qliphy]

@rekovic Can this PR be closed by #36441 ?

[cecilecaillol]

please test

[cecilecaillol]

unhold

[cmsbuild]

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4498eb/21815/summary.html
COMMIT: f4a9def
CMSSW: CMSSW_12_3_X_2022-01-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36103/21815/install.sh to create a dev area with all the needed externals and cmssw changes.

This pull request cannot be automatically merged, could you please rebase it?
You can see the log for git cms-merge-topic here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4498eb/21815/git-merge-result

[cecilecaillol]

@namppl Can you please close this PR? Changes were merged with #36758