Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SiStrip online DQM client for commissioning_run key [12.0.X] #36105

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Nov 12, 2021

backport of #36104

PR description:

It was noticed that during the Fall 2021 LHC beam test the run 346316 acquired with the commissioning_run DQM key, didn't produce all the desired plots (essentially the SiStrip readout view summaries): see link to online DQM.
This based on private tests from @arossi83 (thanks!) is apparently due to the missing process.DQMCommon sequence in the path.
This PR fixes the problem.

PR validation:

Private, but if possible it would be good to do a replay of run 346316 using this branch.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Verbatim backport of #36104

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 12, 2021

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_0_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Nov 12, 2021

@cmsbuild, please test

@francescobrivio
Copy link
Contributor

@ahmad3213 @pmandrik is there a way to organize a Playback of run 346316 with this PR? do you have the streamer files?

@pmandrik
Copy link
Contributor

@ahmad3213 @pmandrik is there a way to organize a Playback of run 346316 with this PR? do you have the streamer files?

hello, @francescobrivio , we do not have run 346316 at playback at the moment, but we requested it from Storage Managers team.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e67212/20505/summary.html
COMMIT: beadf31
CMSSW: CMSSW_12_0_X_2021-11-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36105/20505/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 39
  • DQMHistoTests: Total histograms compared: 2998564
  • DQMHistoTests: Total failures: 11
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2998530
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 38 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 165 log files, 37 edm output root files, 39 DQM output files
  • TriggerResults: no differences found

@pmandrik
Copy link
Contributor

@ahmad3213 @pmandrik is there a way to organize a Playback of run 346316 with this PR? do you have the streamer files?

hello, @francescobrivio , we do not have run 346316 at playback at the moment, but we requested it from Storage Managers team.

Unfortunately, the DQM streams from runs are kept on lustre for 10 days and were removed on November 7th from P5 (which was before our request). Fortunately we found several lumisections still available at DQM machine. The playback is running using them, please check [0].

[0] https://cmsweb.cern.ch/dqm/online-playback/

@mmusich
Copy link
Contributor Author

mmusich commented Nov 15, 2021

Hi @pmandrik

Unfortunately, the DQM streams from runs are kept on lustre for 10 days and were removed on November 7th from P5 (which was before our request). Fortunately we found several lumisections still available at DQM machine. The playback is running using them, please check [0].

Thanks a lot!
The interesting histograms are there:

image

image

you can consider it validated from my side.
If you deploy it at P5 it would be great!
Thanks

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@francescobrivio
Copy link
Contributor

@qliphy @perrotta this is fully signed and already tested in online DQM at P5, please merge at your convenience.
Once this is merged I will ask to be installed in production.

@qliphy
Copy link
Contributor

qliphy commented Nov 15, 2021

+1

@cmsbuild cmsbuild merged commit 0a2d8dc into cms-sw:CMSSW_12_0_X Nov 15, 2021
@mmusich mmusich deleted the fix_sistrip_client_for_commissioning_runs_10_2_X branch November 15, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants