Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

speedup: use cached RhoEtaPhi from caloCellGeometry in EgammaHcalIsolation #36108

Merged
merged 1 commit into from Nov 13, 2021
Merged

speedup: use cached RhoEtaPhi from caloCellGeometry in EgammaHcalIsolation #36108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 6 additions & 5 deletions RecoEgamma/EgammaIsolationAlgos/src/EgammaHcalIsolation.cc
View file
Open in desktop
Expand Up @@ -9,13 +9,14 @@
#include <Math/VectorUtil.h>

//CMSSW includes
#include "RecoEgamma/EgammaIsolationAlgos/interface/EgammaHcalIsolation.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "DataFormats/HcalDetId/interface/HcalDetId.h"
#include "DataFormats/Math/interface/deltaR.h"
#include "DataFormats/RecoCandidate/interface/RecoCandidate.h"
#include "Geometry/CaloGeometry/interface/CaloCellGeometry.h"
#include "Geometry/CommonDetUnit/interface/TrackingGeometry.h"
#include "Geometry/Records/interface/TrackerDigiGeometryRecord.h"
#include "DataFormats/RecoCandidate/interface/RecoCandidate.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "DataFormats/Math/interface/deltaR.h"
#include "RecoEgamma/EgammaIsolationAlgos/interface/EgammaHcalIsolation.h"

double scaleToE(const double &eta) { return 1.; }
double scaleToEt(const double &eta) { return std::sin(2. * std::atan(std::exp(-eta))); }
Expand Down Expand Up @@ -150,7 +151,7 @@ double EgammaHcalIsolation::goodHitEnergy(float pcluEta,
if (!(goodHBe or goodHEe))
return 0.;

const auto phit = caloGeometry_.getPosition(hit.detid());
const auto phit = caloGeometry_.getGeometry(hit.detid())->repPos();
const float phitEta = phit.eta();

if (extIncRule_ == InclusionRule::withinConeAroundCluster or intIncRule_ == InclusionRule::withinConeAroundCluster) {
Expand Down